Backup_Repos/beets
1
0
Fork 0
mirror of https://github.com/beetbox/beets.git synced 2026-01-08 08:56:56 +01:00
Code Issues Projects Releases Wiki Activity

docs & style for #92

Browse source 
We already have a nice plurality() function in beets.util to calculate the most
popular value of something, so I reused that.
This commit is contained in:
Adrian Sampson 2013-02-06 10:55:48 -08:00
parent 19cdd4e907
commit f7f2454134
2 changed files with 24 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
beetsplug/lastgenre/__init__.py
View file

@ -31,7 +31,7 @@ import yaml
from beets import plugins
from beets import ui
from beets.util import normpath
from beets.util import normpath, plurality
from beets import config
from beets import library
@ -282,21 +282,18 @@ class LastGenrePlugin(plugins.BeetsPlugin):
elif obj.albumartist != 'Various Artists':
result = fetch_album_artist_genre(obj)
else:
# For 'Various Artists' pick the most used common tag as
# album_tag
artist_genres = {}
# For "Various Artists", pick the most popular track genre.
item_genres = []
for item in obj.items():
tmp_genre = None
item_genre = None
if 'track' in self.sources:
tmp_genre = fetch_track_genre(item)
if not tmp_genre:
tmp_genre = fetch_artist_genre(item)
if tmp_genre:
artist_genres[tmp_genre] = \
artist_genres.get(tmp_genre, 0) + 1
if len(artist_genres) > 0:
result = filter(lambda k:artist_genres[k] ==
max(artist_genres.values()), artist_genres)[0]
item_genre = fetch_track_genre(item)
if not item_genre:
item_genre = fetch_artist_genre(item)
if item_genre:
item_genres.append(item_genre)
if item_genres:
result, _ = plurality(item_genres)
if result:
return result, 'artist'
@ -332,13 +329,15 @@ class LastGenrePlugin(plugins.BeetsPlugin):
))
for item in album.items():
# If we're using track-level sources, also look up each
# track on the album.
if 'track' in self.sources:
# Fetch track genre only if source is 'track'
item.genre, src = self._get_genre(item)
lib.store(item)
log.info(u'genre for track {0} - {1} ({2}): {3}'.format(
item.artist, item.title, src, item.genre
))
if write:
item.write()
@ -356,8 +355,9 @@ class LastGenrePlugin(plugins.BeetsPlugin):
album.genre, src = self._get_genre(album)
log.debug(u'added last.fm album genre ({0}): {1}'.format(
src, album.genre))
for item in album.items():
if 'track' in self.sources:
if 'track' in self.sources:
for item in album.items():
item.genre, src = self._get_genre(item)
log.debug(u'added last.fm item genre ({0}): {1}'.format(
src, item.genre))

10
docs/plugins/lastgenre.rst
View file

@ -66,13 +66,17 @@ to use your own tree.
Genre Source
------------
When looking up genres for albums or individual tracks, you may prefer to use
a genre tag from the *track* or *artist* instead of the individual entity. To
do so, set the ``source`` configuration value to "track" or "artist", like so::
When looking up genres for albums or individual tracks, you can choose whether
to use Last.fm tags on the album, the artist, or the track. For example, you
might want all the albums for a certain artist to carry the same genre. Set the
``source`` configuration value to "album", "track", or "artist", like so::
lastgenre:
source: artist
The default is "album". When set to "track", the plugin will fetch *both*
album-level and track-level genres for your music when importing albums.
Running Manually
----------------