mirror of
https://github.com/beetbox/beets.git
synced 2025-12-06 16:42:42 +01:00
Findings from PR
This commit is contained in:
parent
2bfc7723fa
commit
f254b33c6e
2 changed files with 10 additions and 8 deletions
|
|
@ -58,9 +58,11 @@ class AcousticBrainzSubmitPlugin(plugins.BeetsPlugin):
|
||||||
self.config.add({
|
self.config.add({
|
||||||
'extractor': u'',
|
'extractor': u'',
|
||||||
'force': False,
|
'force': False,
|
||||||
'dry': False
|
'pretend': False
|
||||||
})
|
})
|
||||||
|
|
||||||
|
self.PROBE_FIELD = 'mood_acoustic'
|
||||||
|
|
||||||
self.extractor = self.config['extractor'].as_str()
|
self.extractor = self.config['extractor'].as_str()
|
||||||
if self.extractor:
|
if self.extractor:
|
||||||
self.extractor = util.normpath(self.extractor)
|
self.extractor = util.normpath(self.extractor)
|
||||||
|
|
@ -108,9 +110,9 @@ class AcousticBrainzSubmitPlugin(plugins.BeetsPlugin):
|
||||||
help=u're-download data when already present'
|
help=u're-download data when already present'
|
||||||
)
|
)
|
||||||
cmd.parser.add_option(
|
cmd.parser.add_option(
|
||||||
u'-d', u'--dry', dest='dry_fetch',
|
u'-p', u'--pretend', dest='pretend_fetch',
|
||||||
action='store_true', default=False,
|
action='store_true', default=False,
|
||||||
help=u'dry run, show files which would be processed'
|
help=u'pretend to perform action, but show only files which would be processed'
|
||||||
)
|
)
|
||||||
cmd.func = self.command
|
cmd.func = self.command
|
||||||
return [cmd]
|
return [cmd]
|
||||||
|
|
@ -131,7 +133,7 @@ class AcousticBrainzSubmitPlugin(plugins.BeetsPlugin):
|
||||||
|
|
||||||
# If file has no mbid skip it.
|
# If file has no mbid skip it.
|
||||||
if not self.opts.force_refetch and not self.config['force']:
|
if not self.opts.force_refetch and not self.config['force']:
|
||||||
mood_str = item.get('mood_acoustic', u'')
|
mood_str = item.get(self.PROBE_FIELD, u'')
|
||||||
if mood_str:
|
if mood_str:
|
||||||
return None
|
return None
|
||||||
|
|
||||||
|
|
@ -140,8 +142,8 @@ class AcousticBrainzSubmitPlugin(plugins.BeetsPlugin):
|
||||||
u'musicbrainz track id.', item)
|
u'musicbrainz track id.', item)
|
||||||
return None
|
return None
|
||||||
|
|
||||||
if self.opts.dry_fetch or self.config['dry']:
|
if self.opts.pretend_fetch or self.config['pretend']:
|
||||||
self._log.info(u'dry run - extract item: {}', item)
|
self._log.info(u'pretend action - extract item: {}', item)
|
||||||
return None
|
return None
|
||||||
|
|
||||||
# Temporary file to save extractor output to, extractor only works
|
# Temporary file to save extractor output to, extractor only works
|
||||||
|
|
|
||||||
|
|
@ -55,8 +55,8 @@ file. The available options are:
|
||||||
- **force**: Analyze items and submit of AcousticBrainz data even for tracks
|
- **force**: Analyze items and submit of AcousticBrainz data even for tracks
|
||||||
that already have it.
|
that already have it.
|
||||||
Default: ``no``.
|
Default: ``no``.
|
||||||
- **dry**: No analyze and submit of AcousticBrainz data but print out the
|
- **pretend**: Do not analyze and submit of AcousticBrainz data but print out
|
||||||
items which would be processed
|
the items which would be processed.
|
||||||
Default: ``no``.
|
Default: ``no``.
|
||||||
|
|
||||||
.. _streaming_extractor_music: https://acousticbrainz.org/download
|
.. _streaming_extractor_music: https://acousticbrainz.org/download
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue