Backup_Repos/beets
1
0
Fork 0
mirror of https://github.com/beetbox/beets.git synced 2025-12-26 18:43:38 +01:00
Code Issues Projects Releases Wiki Activity

Update retry logic

Browse source
This commit is contained in:
Alok Saboo 2023-10-21 09:43:01 -04:00
parent 5dee3e6ef4
commit ee42f79b25
2 changed files with 14 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
beetsplug/spotify.py
View file

@ -157,7 +157,8 @@ class SpotifyPlugin(MetadataSourcePlugin, BeetsPlugin):
with open(self.tokenfile, 'w') as f:
json.dump({'access_token': self.access_token}, f)
def _handle_response(self, request_type, url, params=None):
def _handle_response(self, request_type, url, params=None, retry_count=0,
max_retries=3):
"""Send a request, reauthenticating if necessary.
:param request_type: Type of :class:`Request` constructor,
@ -195,12 +196,17 @@ class SpotifyPlugin(MetadataSourcePlugin, BeetsPlugin):
raise SpotifyAPIError(f'API Error: {e.response.status_code}\n'
f'URL: {url}\nparams: {params}')
elif e.response.status_code == 429:
seconds = response.headers.get('Retry-After',
DEFAULT_WAITING_TIME)
self._log.debug(f'Too many API requests. Retrying after '
f'{seconds} seconds.')
time.sleep(int(seconds) + 1)
return self._handle_response(request_type, url, params=params)
if retry_count < max_retries:
seconds = response.headers.get('Retry-After',
DEFAULT_WAITING_TIME)
self._log.debug(f'Too many API requests. Retrying after '
f'{seconds} seconds.')
time.sleep(int(seconds) + 1)
return self._handle_response(request_type, url,
params=params,
retry_count=retry_count + 1)
else:
raise SpotifyAPIError('Maximum retries reached.')
elif e.response.status_code == 503:
self._log.error('Service Unavailable.')
raise SpotifyAPIError('Service Unavailable.')

1
docs/changelog.rst
View file

@ -142,6 +142,7 @@ New features:
Bug fixes:
* Fix retry-logic for Spotify plugin.
* Fix a crash when the Spotify API timeouts or does not return a `Retry-After` interval.
:bug:`4942`
* :doc:`/plugins/scrub`: Fixed the import behavior where scrubbed database tags