Backup_Repos/beets
1
0
Fork 0
mirror of https://github.com/beetbox/beets.git synced 2026-02-18 05:17:31 +01:00
Code Issues Projects Releases Wiki Activity

Remove conditional logic from lastgenre tests (ref https://github.com/beetbox/beets/pull/6169#issuecomment-3716893013)

Browse source
This commit is contained in:
dunkla 2026-01-10 15:37:55 +01:00
parent c67dea2adb
commit ea67c8efac
1 changed files with 17 additions and 23 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

40
test/plugins/test_lastgenre.py
View file

@ -217,7 +217,7 @@ class LastGenrePluginTest(PluginTestCase):
"prefer_specific": False,
"count": 10,
},
"Blues",
["Blues"],
{
"album": ["Jazz"],
},
@ -233,7 +233,7 @@ class LastGenrePluginTest(PluginTestCase):
"canonical": False,
"prefer_specific": False,
},
"original unknown, Blues",
["original unknown", "Blues"],
{
"album": ["Jazz"],
},
@ -249,7 +249,7 @@ class LastGenrePluginTest(PluginTestCase):
"canonical": False,
"prefer_specific": False,
},
"",
[],
{
"album": ["Jazz"],
},
@ -265,7 +265,7 @@ class LastGenrePluginTest(PluginTestCase):
"canonical": False,
"prefer_specific": False,
},
"original unknown, Blues",
["original unknown", "Blues"],
{
"album": ["Jazz"],
"artist": ["Pop"],
@ -282,7 +282,7 @@ class LastGenrePluginTest(PluginTestCase):
"canonical": False,
"prefer_specific": False,
},
"any genre",
["any genre"],
{
"album": ["Jazz"],
},
@ -298,7 +298,7 @@ class LastGenrePluginTest(PluginTestCase):
"canonical": False,
"prefer_specific": False,
},
"",
[],
{
"album": ["Jazzin"],
},
@ -314,7 +314,7 @@ class LastGenrePluginTest(PluginTestCase):
"canonical": False,
"prefer_specific": False,
},
"unknown genre",
["unknown genre"],
{
"track": None,
"album": None,
@ -334,7 +334,7 @@ class LastGenrePluginTest(PluginTestCase):
"canonical": False,
"prefer_specific": False,
},
"any existing",
["any existing"],
{
"track": None,
"album": None,
@ -354,7 +354,7 @@ class LastGenrePluginTest(PluginTestCase):
"canonical": False,
"prefer_specific": False,
},
"Jazz",
["Jazz"],
{
"track": None,
"album": None,
@ -374,7 +374,7 @@ class LastGenrePluginTest(PluginTestCase):
"canonical": False,
"prefer_specific": False,
},
"Jazz",
["Jazz"],
{
"track": None,
"album": None,
@ -393,7 +393,7 @@ class LastGenrePluginTest(PluginTestCase):
"canonical": False,
"prefer_specific": False,
},
"",
[],
{
"track": None,
"album": None,
@ -412,7 +412,7 @@ class LastGenrePluginTest(PluginTestCase):
"canonical": False,
"prefer_specific": False,
},
"original unknown, Blues, Rock, Folk, Metal",
["original unknown", "Blues", "Rock", "Folk", "Metal"],
{
"album": ["Jazz", "Bebop", "Hardbop"],
},
@ -433,7 +433,7 @@ class LastGenrePluginTest(PluginTestCase):
"canonical": False,
"prefer_specific": False,
},
"not whitelisted original",
["not whitelisted original"],
{
"track": None,
"album": None,
@ -455,7 +455,7 @@ class LastGenrePluginTest(PluginTestCase):
"prefer_specific": False,
"count": 10,
},
"",
[],
{
"album": ["acid techno"],
},
@ -478,7 +478,7 @@ class LastGenrePluginTest(PluginTestCase):
"count": 10,
"extended_debug": True,
},
"detroit techno",
["detroit techno"],
{
"album": ["acid house"],
},
@ -509,7 +509,7 @@ class LastGenrePluginTest(PluginTestCase):
"prefer_specific": False,
"count": 10,
},
"Cosmic Disco",
["Cosmic Disco"],
{
"album": ["Detroit Techno"],
},
@ -546,13 +546,7 @@ def test_get_genre(config_values, item_genre, mock_genres, expected_result):
plugin.setup() # Loads default whitelist and canonicalization tree
item = _common.item()
if item_genre:
if ", " in item_genre:
item.genres = [g.strip() for g in item_genre.split(", ")]
else:
item.genres = [item_genre]
else:
item.genres = []
item.genres = item_genre
# Run
res = plugin._get_genre(item)