Remove unused extra_tags parameter

This commit is contained in:
Šarūnas Nejus 2025-05-19 09:18:06 +01:00
parent 2ec65ed8ca
commit e8e9369bc7
No known key found for this signature in database
GPG key ID: DD28F6704DBE3435
6 changed files with 10 additions and 19 deletions

View file

@ -239,12 +239,7 @@ class BeetsPlugin:
return Distance()
def candidates(
self,
items: list[Item],
artist: str,
album: str,
va_likely: bool,
extra_tags: dict[str, Any] | None = None,
self, items: list[Item], artist: str, album: str, va_likely: bool
) -> Iterator[AlbumInfo]:
"""Return :py:class:`AlbumInfo` candidates that match the given album.
@ -252,9 +247,6 @@ class BeetsPlugin:
:param artist: Album artist
:param album: Album name
:param va_likely: Whether the album is likely to be by various artists
:param extra_tags: is a an optional dictionary of extra tags to search.
Only relevant to :py:class:`MusicBrainzPlugin` autotagger and can be
ignored by other plugins
"""
yield from ()
@ -872,12 +864,7 @@ class MetadataSourcePlugin(Generic[R], BeetsPlugin, metaclass=abc.ABCMeta):
return extract_release_id(self.data_source.lower(), id_string)
def candidates(
self,
items: list[Item],
artist: str,
album: str,
va_likely: bool,
extra_tags: dict[str, Any] | None = None,
self, items: list[Item], artist: str, album: str, va_likely: bool
) -> Iterator[AlbumInfo]:
query_filters = {"album": album}
if not va_likely:

View file

@ -806,7 +806,7 @@ class AutotagStub:
for p in self.patchers:
p.stop()
def candidates(self, items, artist, album, va_likely, extra_tags=None):
def candidates(self, items, artist, album, va_likely):
if self.matching == self.IDENT:
yield self._make_album_match(artist, album, len(items))

View file

@ -361,7 +361,7 @@ class BeatportPlugin(BeetsPlugin):
data_source=self.data_source, info=track_info, config=self.config
)
def candidates(self, items, artist, release, va_likely, extra_tags=None):
def candidates(self, items, artist, release, va_likely):
"""Returns a list of AlbumInfo objects for beatport search results
matching release and artist (if not various).
"""

View file

@ -200,7 +200,7 @@ class AcoustidPlugin(plugins.BeetsPlugin):
dist.add_expr("track_id", info.track_id not in recording_ids)
return dist
def candidates(self, items, artist, album, va_likely, extra_tags=None):
def candidates(self, items, artist, album, va_likely):
albums = []
for relid in prefix(_all_releases(items), MAX_RELEASES):
album = self.mb.album_for_id(relid)

View file

@ -156,7 +156,7 @@ class DiscogsPlugin(BeetsPlugin):
data_source="Discogs", info=track_info, config=self.config
)
def candidates(self, items, artist, album, va_likely, extra_tags=None):
def candidates(self, items, artist, album, va_likely):
"""Returns a list of AlbumInfo objects for discogs search results
matching an album and artist (if not various).
"""

View file

@ -26,6 +26,10 @@ Bug fixes:
For packagers:
* Optional ``extra_tags`` parameter has been removed from
``BeetsPlugin.candidates`` method signature since it is never passed in. If
you override this method in your plugin, feel free to remove this parameter.
Other changes:
2.3.1 (May 14, 2025)