Backup_Repos/beets
1
0
Fork 0
mirror of https://github.com/beetbox/beets.git synced 2025-12-06 16:42:42 +01:00
Code Issues Projects Releases Wiki Activity

Use beets shlex_split instead of shlex.split

Browse source
This commit is contained in:
Jack Wilsdon 2016-05-01 21:31:53 +01:00
parent b4715d61e1
commit e66981c4d8
1 changed files with 3 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
beetsplug/hook.py
View file

@ -16,11 +16,11 @@
from __future__ import division, absolute_import, print_function from __future__ import division, absolute_import, print_function
import string import string
import shlex
import subprocess import subprocess
from beets.plugins import BeetsPlugin from beets.plugins import BeetsPlugin
from beets.ui import _arg_encoding from beets.ui import _arg_encoding
from beets.util import shlex_split
# Sadly we need this class for {} support due to issue 13598 # Sadly we need this class for {} support due to issue 13598
@ -134,17 +134,13 @@ class HookPlugin(BeetsPlugin):
formatter = CodingFormatter(encoding) formatter = CodingFormatter(encoding)
formatted_command = formatter.format(command, event=event, formatted_command = formatter.format(command, event=event,
**kwargs) **kwargs)
encoded_formatted_command = formatted_command.encode(encoding) command_pieces = shlex_split(formatted_command)
command_pieces = shlex.split(encoded_formatted_command)
decoded_command_pieces = map(lambda piece:
piece.decode(encoding),
command_pieces)
self._log.debug(u'running command "{0}" for event {1}', self._log.debug(u'running command "{0}" for event {1}',
formatted_command, event) formatted_command, event)
try: try:
subprocess.Popen(decoded_command_pieces).wait() subprocess.Popen(command_pieces).wait()
except OSError as exc: except OSError as exc:
self._log.error(u'hook for {0} failed: {1}', event, exc) self._log.error(u'hook for {0} failed: {1}', event, exc)