From dc45119a8d1e843fe36ff0ffd031c3b35d48f27d Mon Sep 17 00:00:00 2001 From: Adrian Sampson Date: Sun, 16 Sep 2018 20:52:31 -0400 Subject: [PATCH] Avoid comparing patterns in a test As pointed out here: https://github.com/beetbox/beets/pull/3028#issuecomment-420257867 --- test/test_ui.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/test/test_ui.py b/test/test_ui.py index 77804d3d2..b9039d236 100644 --- a/test/test_ui.py +++ b/test/test_ui.py @@ -800,16 +800,18 @@ class ConfigTest(unittest.TestCase, TestHelper, _common.Assertions): self.run_command('test', lib=None) replacements = self.test_cmd.lib.replacements - self.assertEqual(replacements, [(re.compile(u'[xy]'), 'z')]) + repls = [(p.pattern, s) for p, s in replacements] # Compare patterns. + self.assertEqual(repls, [(u'[xy]', 'z')]) def test_multiple_replacements_parsed(self): with self.write_config_file() as config: config.write("replace: {'[xy]': z, foo: bar}") self.run_command('test', lib=None) replacements = self.test_cmd.lib.replacements - self.assertEqual(replacements, [ - (re.compile(u'[xy]'), u'z'), - (re.compile(u'foo'), u'bar'), + repls = [(p.pattern, s) for p, s in replacements] + self.assertEqual(repls, [ + (u'[xy]', u'z'), + (u'foo', u'bar'), ]) def test_cli_config_option(self):