Backup_Repos/beets
1
0
Fork 0
mirror of https://github.com/beetbox/beets.git synced 2025-12-06 16:42:42 +01:00
Code Issues Projects Releases Wiki Activity

Remove Musixmatch from default enabled sources

Browse source 
Musixmatch are currently blocking all requests with the beets user
agent. See #4585.
This commit is contained in:
Jack Wilsdon 2022-12-31 14:04:25 +00:00
parent 2106f471af
commit dad9d2393d
3 changed files with 13 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
beetsplug/lyrics.py
View file

@ -743,7 +743,9 @@ class LyricsPlugin(plugins.BeetsPlugin):
'fallback': None, 'fallback': None,
'force': False, 'force': False,
'local': False, 'local': False,
'sources': self.SOURCES, # Musixmatch is disabled by default as they are currently blocking
# requests with the beets user agent.
'sources': [s for s in self.SOURCES if s != "musixmatch"],
'dist_thresh': 0.1, 'dist_thresh': 0.1,
}) })
self.config['bing_client_secret'].redact = True self.config['bing_client_secret'].redact = True

5
docs/changelog.rst
View file

@ -129,11 +129,14 @@ For packagers:
:bug:`4167` :bug:`4167`
* The minimum required version of :pypi:`mediafile` is now 0.9.0. * The minimum required version of :pypi:`mediafile` is now 0.9.0.
Other new things: Other changes:
* :doc:`/plugins/limit`: Limit query results to head or tail (``lslimit`` * :doc:`/plugins/limit`: Limit query results to head or tail (``lslimit``
command only) command only)
* :doc:`/plugins/fish`: Add ``--output`` option. * :doc:`/plugins/fish`: Add ``--output`` option.
* :doc:`/plugins/lyrics`: Remove Musixmatch from default enabled sources as
they are currently blocking requests from the beets user agent.
:bug:`4585`
1.6.0 (November 27, 2021) 1.6.0 (November 27, 2021)
------------------------- -------------------------

14
docs/plugins/lyrics.rst
View file

@ -2,10 +2,9 @@ Lyrics Plugin
============= =============
The ``lyrics`` plugin fetches and stores song lyrics from databases on the Web. The ``lyrics`` plugin fetches and stores song lyrics from databases on the Web.
Namely, the current version of the plugin uses `Musixmatch`_, `Genius.com`_, Namely, the current version of the plugin uses `Genius.com`_, `Tekstowo.pl`_,
`Tekstowo.pl`_, and, optionally, the Google custom search API. and, optionally, the Google custom search API.
.. _Musixmatch: https://www.musixmatch.com/
.. _Genius.com: https://genius.com/ .. _Genius.com: https://genius.com/
.. _Tekstowo.pl: https://www.tekstowo.pl/ .. _Tekstowo.pl: https://www.tekstowo.pl/
@ -59,9 +58,9 @@ configuration file. The available options are:
sources known to be scrapeable. sources known to be scrapeable.
- **sources**: List of sources to search for lyrics. An asterisk ``*`` expands - **sources**: List of sources to search for lyrics. An asterisk ``*`` expands
to all available sources. to all available sources.
Default: ``google musixmatch genius tekstowo``, i.e., all the Default: ``google genius tekstowo``, i.e., all the available sources. The
available sources. The ``google`` source will be automatically ``google`` source will be automatically deactivated if no ``google_API_key``
deactivated if no ``google_API_key`` is setup. is setup.
The ``google``, ``genius``, and ``tekstowo`` sources will only be enabled if The ``google``, ``genius``, and ``tekstowo`` sources will only be enabled if
BeautifulSoup is installed. BeautifulSoup is installed.
@ -139,8 +138,7 @@ configuration option to your key.
Then add ``google`` to the list of sources in your configuration (or use Then add ``google`` to the list of sources in your configuration (or use
default list, which includes it as long as you have an API key). default list, which includes it as long as you have an API key).
If you use default ``google_engine_ID``, we recommend limiting the sources to If you use default ``google_engine_ID``, we recommend limiting the sources to
``musixmatch google`` as the other sources are already included in the Google ``google`` as the other sources are already included in the Google results.
results.
.. _register for a Google API key: https://console.developers.google.com/ .. _register for a Google API key: https://console.developers.google.com/