From d7b7d60111c8f8d28737306af1007bef2da92316 Mon Sep 17 00:00:00 2001 From: J0J0 Todos Date: Wed, 23 Aug 2023 06:32:17 +0200 Subject: [PATCH] Refactor Album.store for code readability --- beets/library.py | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/beets/library.py b/beets/library.py index 71ce251cd..405b546e2 100644 --- a/beets/library.py +++ b/beets/library.py @@ -1383,12 +1383,13 @@ class Album(LibModel): track_updates = {} track_deletes = set() for key in self._dirty: - if key in self.item_keys and inherit: # Fixed attr - track_updates[key] = self[key] - elif key not in self and inherit: # Fixed or flex attr - track_deletes.add(key) - elif key != 'id' and inherit: # Could be a flex attr or id (fixed) - track_updates[key] = self[key] + if inherit: + if key in self.item_keys: # is a fixed attribute + track_updates[key] = self[key] + elif key not in self: # is a fixed or a flexible attribute + track_deletes.add(key) + elif key != 'id': # is a flexible attribute + track_updates[key] = self[key] with self._db.transaction(): super().store(fields)