Implement comments & add to changelog

This commit is contained in:
ybnd 2020-06-04 16:43:42 +02:00
parent b239a0b3d2
commit d1f3d664d7
2 changed files with 4 additions and 2 deletions

View file

@ -782,7 +782,7 @@ class LyricsPlugin(plugins.BeetsPlugin):
ui.print_(item.lyrics)
if opts.writerest:
self.appendrest(opts.writerest, item)
if opts.writerest and len(items) > 0:
if opts.writerest and items:
# flush last artist & write to ReST
self.writerest(opts.writerest)
ui.print_(u'ReST files generated. to build, use one of:')
@ -831,7 +831,6 @@ class LyricsPlugin(plugins.BeetsPlugin):
with open(path, 'wb') as output:
output.write(self.rest.encode('utf-8'))
def writerest_indexes(self, directory):
"""Write conf.py and index.rst files necessary for Sphinx

View file

@ -207,6 +207,9 @@ Fixes:
* :doc:`/plugins/lyrics`: Adapt the Genius backend to changes in markup to
reduce the scraping failure rate.
:bug:`3535` :bug:`3594`
* :doc:`/plugins/lyrics`: Fix crash when writing ReST files for a query without
results or fetched lyrics
:bug:`2805`
For plugin developers: