From 614f8eda885ca43dd682f19212522bc9a9f02d4c Mon Sep 17 00:00:00 2001 From: jean-marie winters Date: Tue, 3 Mar 2015 23:02:02 +0100 Subject: [PATCH 1/4] added tests for bs1770gain --- test/test_replaygain.py | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/test/test_replaygain.py b/test/test_replaygain.py index 64d65b006..84306a299 100644 --- a/test/test_replaygain.py +++ b/test/test_replaygain.py @@ -33,6 +33,10 @@ if any(has_program(cmd, ['-v']) for cmd in ['mp3gain', 'aacgain']): else: GAIN_PROG_AVAILABLE = False +if has_program('bs1770gain', ['--replaygain']): + LOUDNESS_PROG_AVAILABLE = True +else: + LOUDNESS_PROG_AVAILABLE = False class ReplayGainCliTestBase(TestHelper): @@ -123,6 +127,11 @@ class ReplayGainCmdCliTest(ReplayGainCliTestBase, unittest.TestCase): backend = u'command' +@unittest.skipIf(not LOUDNESS_PROG_AVAILABLE, 'bs1770gain cannot be found') +class ReplayGainLdnsCliTest(ReplayGainCliTestBase, unittest.TestCase): + backend = u'bs1770gain' + + def suite(): return unittest.TestLoader().loadTestsFromName(__name__) From 5d9bb5059a2b126b964b28f93fe4e0d6e010394f Mon Sep 17 00:00:00 2001 From: jean-marie winters Date: Wed, 4 Mar 2015 07:20:53 +0100 Subject: [PATCH 2/4] corrected typo --- test/test_replaygain.py | 1 + 1 file changed, 1 insertion(+) diff --git a/test/test_replaygain.py b/test/test_replaygain.py index 84306a299..ba2628fef 100644 --- a/test/test_replaygain.py +++ b/test/test_replaygain.py @@ -38,6 +38,7 @@ if has_program('bs1770gain', ['--replaygain']): else: LOUDNESS_PROG_AVAILABLE = False + class ReplayGainCliTestBase(TestHelper): def setUp(self): From 0d70db39660132d09564736bf3894381c79a769a Mon Sep 17 00:00:00 2001 From: jmwatte Date: Fri, 6 Mar 2015 20:36:06 +0100 Subject: [PATCH 3/4] Update replaygain.rst --- docs/plugins/replaygain.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/plugins/replaygain.rst b/docs/plugins/replaygain.rst index f08a23953..955d46109 100644 --- a/docs/plugins/replaygain.rst +++ b/docs/plugins/replaygain.rst @@ -83,7 +83,7 @@ In order to use this backend, you will need to install the bs1770gain command-li * goto `bs1770gain`_ and follow the download instructions * make sure it is in your $PATH -.. _bs1770gain: bs1770gain.sourceforge.net +.. _bs1770gain:http://bs1770gain.sourceforge.net Then, enable the plugin (see :ref:`using-plugins`) and specify the backend in your configuration file:: From da4a5d079782238d88d01653be74ee195cb82776 Mon Sep 17 00:00:00 2001 From: jmwatte Date: Fri, 6 Mar 2015 22:28:59 +0100 Subject: [PATCH 4/4] fix bs1770gain link --- docs/plugins/replaygain.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/plugins/replaygain.rst b/docs/plugins/replaygain.rst index cbb0de129..3411d3d40 100644 --- a/docs/plugins/replaygain.rst +++ b/docs/plugins/replaygain.rst @@ -83,7 +83,7 @@ In order to use this backend, you will need to install the bs1770gain command-li * goto `bs1770gain`_ and follow the download instructions * make sure it is in your $PATH -.. _bs1770gain:http://bs1770gain.sourceforge.net +.. _bs1770gain: http://bs1770gain.sourceforge.net/ Then, enable the plugin (see :ref:`using-plugins`) and specify the backend in your configuration file::