Backup_Repos/beets
1
0
Fork 0
mirror of https://github.com/beetbox/beets.git synced 2025-12-08 01:23:09 +01:00
Code Issues Projects Releases Wiki Activity

Merge pull request #3767 from jackwilsdon/skip-azlyrics

Browse source 
Skip AZLyrics on GitHub actions
This commit is contained in:
Adrian Sampson 2020-10-05 20:48:49 -04:00 committed by GitHub
commit ce80459110
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
test/test_lyrics.py
View file

@ -270,7 +270,9 @@ class LyricsPluginSourcesTest(LyricsGoogleBaseTest):
DEFAULT_SOURCES = [ DEFAULT_SOURCES = [
# dict(artist=u'Santana', title=u'Black magic woman', # dict(artist=u'Santana', title=u'Black magic woman',
# backend=lyrics.MusiXmatch), # backend=lyrics.MusiXmatch),
dict(DEFAULT_SONG, backend=lyrics.Genius), dict(DEFAULT_SONG, backend=lyrics.Genius,
# GitHub actions is on some form of Cloudflare blacklist.
skip=os.environ.get('GITHUB_ACTIONS') == 'true'),
] ]
GOOGLE_SOURCES = [ GOOGLE_SOURCES = [
@ -279,7 +281,9 @@ class LyricsPluginSourcesTest(LyricsGoogleBaseTest):
path=u'/lyrics/view/the_beatles/lady_madonna'), path=u'/lyrics/view/the_beatles/lady_madonna'),
dict(DEFAULT_SONG, dict(DEFAULT_SONG,
url=u'http://www.azlyrics.com', url=u'http://www.azlyrics.com',
path=u'/lyrics/beatles/ladymadonna.html'), path=u'/lyrics/beatles/ladymadonna.html',
# AZLyrics returns a 403 on GitHub actions.
skip=os.environ.get('GITHUB_ACTIONS') == 'true'),
dict(DEFAULT_SONG, dict(DEFAULT_SONG,
url=u'http://www.chartlyrics.com', url=u'http://www.chartlyrics.com',
path=u'/_LsLsZ7P4EK-F-LD4dJgDQ/Lady+Madonna.aspx'), path=u'/_LsLsZ7P4EK-F-LD4dJgDQ/Lady+Madonna.aspx'),
@ -327,11 +331,8 @@ class LyricsPluginSourcesTest(LyricsGoogleBaseTest):
"""Test default backends with songs known to exist in respective databases. """Test default backends with songs known to exist in respective databases.
""" """
errors = [] errors = []
# GitHub actions seems to be on a Cloudflare blacklist, so we can't # Don't test any sources marked as skipped.
# contact genius. sources = [s for s in self.DEFAULT_SOURCES if not s.get("skip", False)]
sources = [s for s in self.DEFAULT_SOURCES if
s['backend'] != lyrics.Genius or
os.environ.get('GITHUB_ACTIONS') != 'true']
for s in sources: for s in sources:
res = s['backend'](self.plugin.config, self.plugin._log).fetch( res = s['backend'](self.plugin.config, self.plugin._log).fetch(
s['artist'], s['title']) s['artist'], s['title'])
@ -346,7 +347,9 @@ class LyricsPluginSourcesTest(LyricsGoogleBaseTest):
"""Test if lyrics present on websites registered in beets google custom """Test if lyrics present on websites registered in beets google custom
search engine are correctly scraped. search engine are correctly scraped.
""" """
for s in self.GOOGLE_SOURCES: # Don't test any sources marked as skipped.
sources = [s for s in self.GOOGLE_SOURCES if not s.get("skip", False)]
for s in sources:
url = s['url'] + s['path'] url = s['url'] + s['path']
res = lyrics.scrape_lyrics_from_html( res = lyrics.scrape_lyrics_from_html(
raw_backend.fetch_url(url)) raw_backend.fetch_url(url))