From cb783d11c3989f1045aaab9e0aea059bfe47838b Mon Sep 17 00:00:00 2001 From: Adrian Sampson Date: Tue, 4 Feb 2014 23:19:34 -0800 Subject: [PATCH] style and changelog for #525 --- beets/ui/commands.py | 14 +++++++------- docs/changelog.rst | 2 ++ 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/beets/ui/commands.py b/beets/ui/commands.py index 8c3661171..5ee9b3441 100644 --- a/beets/ui/commands.py +++ b/beets/ui/commands.py @@ -1157,14 +1157,14 @@ def modify_items(lib, mods, query, write, move, album, confirm): # Still something to do? if not changed: - print_('No modification to perform.') + print_('No changes to make.') return - else: - # Confirm. - if confirm: - extra = ' and write tags' if write else '' - if not ui.input_yn('Really modify%s (Y/n)?' % extra): - return + + # Confirm action. + if confirm: + extra = ' and write tags' if write else '' + if not ui.input_yn('Really modify%s (Y/n)?' % extra): + return # Apply changes to database. with lib.transaction(): diff --git a/docs/changelog.rst b/docs/changelog.rst index 43d9c08ed..918cba182 100644 --- a/docs/changelog.rst +++ b/docs/changelog.rst @@ -65,6 +65,8 @@ Other little fixes: * :doc:`/plugins/convert`: Transcoding should now work on Windows. * :doc:`/plugins/duplicates`: The ``move`` and ``copy`` destination arguments are now treated as directories. Thanks to Pedro Silva. +* The :ref:`modify-cmd` command now skips confirmation and prints a message if + no changes are necessary. Thanks to brilnius. 1.3.2 (December 22, 2013)