Merge pull request #3009 from vvvrrooomm/bug_3008

replaygain: albumpeak on large collections is calculated as average,not maximum (bug 3008)
This commit is contained in:
Adrian Sampson 2018-08-20 14:56:52 -07:00 committed by GitHub
commit c5c352ef87
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions

View file

@ -181,9 +181,9 @@ class Bs1770gainBackend(Backend):
i += 1
returnchunk = self.compute_chunk_gain(chunk, is_album)
albumgaintot += returnchunk[-1].gain
albumpeaktot += returnchunk[-1].peak
albumpeaktot = max(albumpeaktot, returnchunk[-1].peak)
returnchunks = returnchunks + returnchunk[0:-1]
returnchunks.append(Gain(albumgaintot / i, albumpeaktot / i))
returnchunks.append(Gain(albumgaintot / i, albumpeaktot))
return returnchunks
else:
return self.compute_chunk_gain(items, is_album)

View file

@ -23,6 +23,8 @@ New features:
* The `absubmit` plugin now works in parallel (on Python 3 only).
Thanks to :user:`bemeurer`.
:bug:`2442`
* replaygain: albumpeak on large collections is calculated as average, not maximum
:bug:`3008`
Fixes: