From c20c62409d8d51471b8668c68b1d80959cf8f2a2 Mon Sep 17 00:00:00 2001 From: Thomas Scholtes Date: Sat, 26 Apr 2014 19:47:50 +0200 Subject: [PATCH] convert: log error instead of crashing --- beetsplug/convert.py | 7 ++++++- docs/changelog.rst | 2 ++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/beetsplug/convert.py b/beetsplug/convert.py index 6e3f91a03..20381c869 100644 --- a/beetsplug/convert.py +++ b/beetsplug/convert.py @@ -190,7 +190,12 @@ def convert_item(dest_dir, keep_new, path_formats): if album: artpath = album.artpath if artpath: - _embed(artpath, [item]) + try: + _embed(artpath, [item.path]) + except IOError as exc: + log.warn(u'could not embed cover art in {0}: {1}' + .format(util.displayable_path(item.path), + exc)) plugins.send('after_convert', item=item, dest=dest, keepnew=keep_new) diff --git a/docs/changelog.rst b/docs/changelog.rst index 087eeb151..441776575 100644 --- a/docs/changelog.rst +++ b/docs/changelog.rst @@ -27,6 +27,8 @@ Fixes: stream by ignoring it. Thanks to brunal. * :doc:`/plugins/fetchart`: Log an error instead of crashing when tag manipulation fails. +* :doc:`/plugins/convert`: Log an error instead of crashing when + embedding album art fails. 1.3.5 (April 15, 2014)