From 8e4047345371322dcaef4ce84ad76a32b4797031 Mon Sep 17 00:00:00 2001 From: Dickson Date: Sat, 26 Feb 2022 21:15:28 +0800 Subject: [PATCH 1/3] fix: dont deduplicate matches if musicbrainz ID is not set for album candidates --- beets/autotag/match.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/beets/autotag/match.py b/beets/autotag/match.py index d352a013f..3061aa39b 100644 --- a/beets/autotag/match.py +++ b/beets/autotag/match.py @@ -357,8 +357,8 @@ def _add_candidate(items, results, info): log.debug('No tracks.') return - # Don't duplicate. - if info.album_id in results: + # Prevent duplicates + if info.album_id and info.album_id in results: log.debug('Duplicate.') return From 6d6bb51fde7c75dea996ba2b9ebadf7e7751849b Mon Sep 17 00:00:00 2001 From: Dickson Date: Sun, 27 Feb 2022 13:28:17 +0800 Subject: [PATCH 2/3] Update changelog --- docs/changelog.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/changelog.rst b/docs/changelog.rst index 1c7ab25ac..877fb32ed 100644 --- a/docs/changelog.rst +++ b/docs/changelog.rst @@ -15,6 +15,7 @@ New features: Bug fixes: +* Fix autotagger marking all albums without a musicbrainz id as a duplicate * :doc:`/plugins/convert`: Resize album art when embedding :bug:`2116` * :doc:`/plugins/deezer`: Fix auto tagger pagination issues (fetch beyond the From 5e057078a609ae604a179ae3a73c062cc9c6931c Mon Sep 17 00:00:00 2001 From: Adrian Sampson Date: Sun, 27 Feb 2022 14:01:48 -0500 Subject: [PATCH 3/3] Slight rewording --- beets/autotag/match.py | 2 +- docs/changelog.rst | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/beets/autotag/match.py b/beets/autotag/match.py index 3061aa39b..814738cd1 100644 --- a/beets/autotag/match.py +++ b/beets/autotag/match.py @@ -357,7 +357,7 @@ def _add_candidate(items, results, info): log.debug('No tracks.') return - # Prevent duplicates + # Prevent duplicates. if info.album_id and info.album_id in results: log.debug('Duplicate.') return diff --git a/docs/changelog.rst b/docs/changelog.rst index 877fb32ed..7135ecb3e 100644 --- a/docs/changelog.rst +++ b/docs/changelog.rst @@ -15,7 +15,9 @@ New features: Bug fixes: -* Fix autotagger marking all albums without a musicbrainz id as a duplicate +* The autotagger no longer considers all matches without a MusicBrainz ID as + duplicates of each other. + :bug:`4299` * :doc:`/plugins/convert`: Resize album art when embedding :bug:`2116` * :doc:`/plugins/deezer`: Fix auto tagger pagination issues (fetch beyond the