From bca6d2af018cd8217b543184bf5aefccfa069aac Mon Sep 17 00:00:00 2001 From: Johnny Robeson Date: Fri, 9 Dec 2016 00:52:24 -0500 Subject: [PATCH] Remove requests/urllib3 logging override in discogs Discog plugin overrides the global logging for `requests` for a reason that seems no longer valid. I can't seem to reproduce the logging behavior mentioned in the preceding comment, so I'm removing it. If we do want to modify `requests` logging in the future, then we should hook it into beets verbose logging. --- beetsplug/discogs.py | 5 ----- 1 file changed, 5 deletions(-) diff --git a/beetsplug/discogs.py b/beetsplug/discogs.py index 97834c500..28b863d4b 100644 --- a/beetsplug/discogs.py +++ b/beetsplug/discogs.py @@ -19,7 +19,6 @@ discogs-client library. from __future__ import division, absolute_import, print_function import beets.ui -from beets import logging from beets import config from beets.autotag.hooks import AlbumInfo, TrackInfo, Distance from beets.plugins import BeetsPlugin @@ -38,10 +37,6 @@ import traceback from string import ascii_lowercase -# Silence spurious INFO log lines generated by urllib3. -urllib3_logger = logging.getLogger('requests.packages.urllib3') -urllib3_logger.setLevel(logging.CRITICAL) - USER_AGENT = u'beets/{0} +http://beets.io/'.format(beets.__version__) # Exceptions that discogs_client should really handle but does not.