From b9bac391a91e332d7eb2de913cd21dc41fc13cc0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Schieli?= <cschieli@gmail.com>
Date: Sun, 18 Mar 2018 15:06:18 +0100
Subject: [PATCH] Really fix album replaygain calculation with gstreamer
 backend.

Fixes #2845
---
 beetsplug/replaygain.py | 21 ++++++++++-----------
 docs/changelog.rst      |  1 +
 2 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/beetsplug/replaygain.py b/beetsplug/replaygain.py
index a7064451a..a7eb81b5c 100644
--- a/beetsplug/replaygain.py
+++ b/beetsplug/replaygain.py
@@ -613,16 +613,6 @@ class GStreamerBackend(Backend):
 
         self._file = self._files.pop(0)
 
-        # Disconnect the decodebin element from the pipeline, set its
-        # state to READY to to clear it.
-        self._decbin.unlink(self._conv)
-        self._decbin.set_state(self.Gst.State.READY)
-
-        # Set a new file on the filesrc element, can only be done in the
-        # READY state
-        self._src.set_state(self.Gst.State.READY)
-        self._src.set_property("location", py3_path(syspath(self._file.path)))
-
         # Ensure the filesrc element received the paused state of the
         # pipeline in a blocking manner
         self._src.sync_state_with_parent()
@@ -633,9 +623,18 @@ class GStreamerBackend(Backend):
         self._decbin.sync_state_with_parent()
         self._decbin.get_state(self.Gst.CLOCK_TIME_NONE)
 
+        # Disconnect the decodebin element from the pipeline, set its
+        # state to READY to to clear it.
+        self._decbin.unlink(self._conv)
+        self._decbin.set_state(self.Gst.State.READY)
+
+        # Set a new file on the filesrc element, can only be done in the
+        # READY state
+        self._src.set_state(self.Gst.State.READY)
+        self._src.set_property("location", py3_path(syspath(self._file.path)))
+
         self._decbin.link(self._conv)
         self._pipe.set_state(self.Gst.State.READY)
-        self._pipe.set_state(self.Gst.State.PLAYING)
 
         return True
 
diff --git a/docs/changelog.rst b/docs/changelog.rst
index b55ec4904..4828bcc2d 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -82,6 +82,7 @@ Fixes:
 * Partially fix bash completion for subcommand names that contain hyphens.
   :bug:`2836` :bug:`2837`
   Thanks to :user:`jhermann`.
+* Really fix album replaygain calculation with gstreamer backend. :bug:`2846`
 
 For developers: