From b79c025142602e9be8d1d6682d4dde98326cc05f Mon Sep 17 00:00:00 2001
From: Bruno Cauet <brunocauet@gmail.com>
Date: Mon, 16 Mar 2015 18:36:08 +0100
Subject: [PATCH] CLI tests for smartplaylist plugin

No import CLI test.
---
 beetsplug/smartplaylist.py |  6 +++--
 test/test_smartplaylist.py | 48 +++++++++++++++++++++++++++++++-------
 2 files changed, 44 insertions(+), 10 deletions(-)

diff --git a/beetsplug/smartplaylist.py b/beetsplug/smartplaylist.py
index e89a43cf7..3e23f8407 100644
--- a/beetsplug/smartplaylist.py
+++ b/beetsplug/smartplaylist.py
@@ -62,8 +62,10 @@ class SmartPlaylistPlugin(BeetsPlugin):
                          for name, q, a_q in self._unmatched_playlists
                          if name in args}
             if not playlists:
-                # raise UserError
-                pass
+                raise ui.UserError('No playlist matching any of {0} '
+                                   'found'.format([name for name, _, _ in
+                                                   self._unmatched_playlists]))
+
             self._matched_playlists = playlists
             self._unmatched_playlists -= playlists
         else:
diff --git a/test/test_smartplaylist.py b/test/test_smartplaylist.py
index 83bb4543f..ac6ff921a 100644
--- a/test/test_smartplaylist.py
+++ b/test/test_smartplaylist.py
@@ -15,7 +15,7 @@
 from __future__ import (division, absolute_import, print_function,
                         unicode_literals)
 
-from os import path
+from os import path, remove
 from tempfile import mkdtemp
 from shutil import rmtree
 
@@ -25,6 +25,7 @@ from beetsplug.smartplaylist import SmartPlaylistPlugin
 from beets.library import Item, Album, parse_query_string
 from beets.dbcore import OrQuery
 from beets.util import syspath
+from beets.ui import UserError
 from beets import config
 
 from test._common import unittest
@@ -130,18 +131,49 @@ class SmartPlaylistTest(unittest.TestCase):
         lib.albums.assert_called_once_with(a_q)
 
         m3u_filepath = path.join(dir, pl[0])
-        self.assertTrue(path.exists(m3u_filepath), m3u_filepath)
-
+        self.assertTrue(path.exists(m3u_filepath))
         with open(syspath(m3u_filepath), 'r') as f:
-            content = f.readlines()
+            content = f.read()
         rmtree(dir)
 
-        self.assertEqual(content, ["/tagada.mp3\n"])
+        self.assertEqual(content, "/tagada.mp3\n")
 
 
 class SmartPlaylistCLITest(unittest.TestCase, TestHelper):
-    def test_import(self):
-        pass
+    def setUp(self):
+        self.setup_beets()
+
+        self.item = self.add_item()
+        config['smartplaylist']['playlists'].set([
+            {'name': 'my_playlist.m3u',
+             'query': self.item.title},
+            {'name': 'all.m3u',
+             'query': ''}
+        ])
+        config['smartplaylist']['playlist_dir'].set(self.temp_dir)
+        self.load_plugins('smartplaylist')
+
+    def tearDown(self):
+        self.unload_plugins()
+        self.teardown_beets()
 
     def test_splupdate(self):
-        pass
+        with self.assertRaises(UserError):
+            self.run_with_output('splupdate', 'tagada')
+
+        self.run_with_output('splupdate', 'my_playlist')
+        m3u_path = path.join(self.temp_dir, 'my_playlist.m3u')
+        self.assertTrue(path.exists(m3u_path))
+        with open(m3u_path, 'r') as f:
+            self.assertEqual(f.read(), self.item.path + b"\n")
+        remove(m3u_path)
+
+        self.run_with_output('splupdate', 'my_playlist.m3u')
+        with open(m3u_path, 'r') as f:
+            self.assertEqual(f.read(), self.item.path + b"\n")
+        remove(m3u_path)
+
+        self.run_with_output('splupdate')
+        for name in ('my_playlist.m3u', 'all.m3u'):
+            with open(path.join(self.temp_dir, name), 'r') as f:
+                self.assertEqual(f.read(), self.item.path + b"\n")