Backup_Repos/beets
1
0
Fork 0
mirror of https://github.com/beetbox/beets.git synced 2025-12-06 08:39:17 +01:00
Code Issues Projects Releases Wiki Activity

slightly reduced the number of unnecessary tests

Browse source 
--HG--
extra : convert_revision : svn%3A41726ec3-264d-0410-9c23-a9f1637257cc/trunk%4088
This commit is contained in:
adrian.sampson 2008-08-25 07:15:58 +00:00
parent 585c10b4db
commit b294b2e1f9
1 changed files with 12 additions and 34 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

46
test/test_mediafile.py
View file

@ -70,6 +70,7 @@ def MakeWritingTest(path, correct_dict, field, testsuffix='_test'):
correct_dicts = {
# All of the fields iTunes supports that we do also.
'full': {
'title': u'full',
'artist': u'the artist',
@ -90,47 +91,22 @@ correct_dicts = {
'comp': True
},
# Additional coverage for common cases when "total" fields are unset. Created
# with iTunes.
'partial': {
'title': u'partial',
'artist': u'the artist',
'album': u'the album',
'genre': u'',
'composer': u'',
'grouping': u'',
'year': 0,
'month': 0,
'day': 0,
'track': 2,
'tracktotal': 0,
'disc': 4,
'disctotal': 0,
'lyrics': u'',
'comments': u'',
'bpm': 0,
'comp': False
'disctotal': 0
},
'min': {
'title': u'min',
'artist': u'',
'album': u'',
'genre': u'',
'composer': u'',
'grouping': u'',
'year': 0,
'month': 0,
'day': 0,
'track': 0,
'tracktotal': 0,
'disc': 0,
'disctotal': 0,
'lyrics': u'',
'comments': u'',
'bpm': 0,
'comp': False
'disctotal': 0
},
# empty.mp3 has had its ID3 tag deleted with mp3info -d
# ID3 tag deleted with `mp3info -d`. Tests default values.
'empty': {
'title': u'',
'artist': u'',
@ -151,7 +127,7 @@ correct_dicts = {
'comp': False
},
# full release date
# Full release date.
'date': {
'year': 1987,
'month': 3,
@ -160,11 +136,12 @@ correct_dicts = {
}
def suite_for_file(path, correct_dict):
def suite_for_file(path, correct_dict, writing=True):
s = unittest.TestSuite()
for field in correct_dict:
s.addTest(MakeReadingTest(path, correct_dict, field)())
if not ( field == 'month' and correct_dict['year'] == 0
if writing and \
not ( field == 'month' and correct_dict['year'] == 0
or field == 'day' and correct_dict['month'] == 0):
# ensure that we don't test fields that can't be modified
s.addTest(MakeWritingTest(path, correct_dict, field)())
@ -182,7 +159,8 @@ def suite():
# Special test for missing ID3 tag.
s.addTest(suite_for_file(os.path.join('rsrc', 'empty.mp3'),
correct_dicts['empty']))
correct_dicts['empty'],
writing=False))
# Special test for advanced release date.
s.addTest(suite_for_file(os.path.join('rsrc', 'date.mp3'),