From aaafba4d28c9a42090baa3eecbc75de1d7e4b474 Mon Sep 17 00:00:00 2001 From: Adrian Sampson Date: Sun, 21 Apr 2013 20:41:01 -0700 Subject: [PATCH] changelog for #254 --- beetsplug/lastgenre/__init__.py | 1 - docs/changelog.rst | 3 +++ docs/plugins/lastgenre.rst | 5 +++-- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/beetsplug/lastgenre/__init__.py b/beetsplug/lastgenre/__init__.py index e54c32bab..e26ade1fc 100644 --- a/beetsplug/lastgenre/__init__.py +++ b/beetsplug/lastgenre/__init__.py @@ -348,7 +348,6 @@ class LastGenrePlugin(plugins.BeetsPlugin): def imported(self, session, task): """Event hook called when an import task finishes.""" - if task.is_album: album = session.lib.get_album(task.album_id) album.genre, src = self._get_genre(album) diff --git a/docs/changelog.rst b/docs/changelog.rst index 18e02c009..661c0d811 100644 --- a/docs/changelog.rst +++ b/docs/changelog.rst @@ -29,6 +29,9 @@ Changelog `Tomahawk`_ collections. And file transfers now have a "Content-Length" header. Thanks to Uwe L. Korn. * :doc:`/plugins/lastgenre`: Fix an error when using genre canonicalization. +* :doc:`/plugins/lastgenre`: The ``force`` config option now defaults to true + and controls the behavior of the import hook. (Previously, new genres were + always forced during import.) .. _Tomahawk: http://www.tomahawk-player.org/ diff --git a/docs/plugins/lastgenre.rst b/docs/plugins/lastgenre.rst index c08b90204..043f6e163 100644 --- a/docs/plugins/lastgenre.rst +++ b/docs/plugins/lastgenre.rst @@ -35,8 +35,9 @@ Wikipedia`_. .. _pylast: http://code.google.com/p/pylast/ .. _script that scrapes Wikipedia: https://gist.github.com/1241307 -Switch ``force`` flag to False to keep the original genre when member -of the whitelist. +By default, beets will always fetch new genres, even if the files already have +once. To instead leave genres in place in when they pass the whitelist, set +the ``force`` option to "no". If no genre is found, the file will be left unchanged. To instead specify a fallback genre, use the ``fallback`` configuration option. You can, of