From a6be28a65eef474cc98af35935eb4b9545115cd7 Mon Sep 17 00:00:00 2001 From: Adrian Sampson Date: Fri, 23 Feb 2018 18:18:32 -0500 Subject: [PATCH] Fix #2817: `drop` in configuration was ignored This was overridden by the default CLI option. Now the default for the config option is None, meaning no change to the config. --- beetsplug/ftintitle.py | 2 +- docs/changelog.rst | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/beetsplug/ftintitle.py b/beetsplug/ftintitle.py index 1060a2dd8..9303f9cfc 100644 --- a/beetsplug/ftintitle.py +++ b/beetsplug/ftintitle.py @@ -89,7 +89,7 @@ class FtInTitlePlugin(plugins.BeetsPlugin): self._command.parser.add_option( u'-d', u'--drop', dest='drop', - action='store_true', default=False, + action='store_true', default=None, help=u'drop featuring from artists and ignore title update') if self.config['auto']: diff --git a/docs/changelog.rst b/docs/changelog.rst index a38d5504a..d09bab826 100644 --- a/docs/changelog.rst +++ b/docs/changelog.rst @@ -56,6 +56,9 @@ Fixes: incompatible between the source and target file formats. :bug:`2814` Thanks to :user:`autrimpo`. +* :doc:`/plugins/ftintitle`: The ``drop`` config option had no effect; it now + does what it says it should do. + :bug:`2817` For developers: