From 9fd0e1d3fec96e2587a40513f801ab54c1dbe864 Mon Sep 17 00:00:00 2001 From: Adrian Sampson Date: Mon, 14 Apr 2014 10:35:20 -0700 Subject: [PATCH] fix #687: template indexes in logging statements --- beetsplug/replaygain.py | 8 ++++---- docs/changelog.rst | 1 + 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/beetsplug/replaygain.py b/beetsplug/replaygain.py index 3ef86c105..0c1b57115 100644 --- a/beetsplug/replaygain.py +++ b/beetsplug/replaygain.py @@ -550,10 +550,10 @@ class ReplayGainPlugin(BeetsPlugin): if write: item.try_write() except ReplayGainError as e: - log.warn(u"ReplayGain error: {1}".format(e)) + log.warn(u"ReplayGain error: {0}".format(e)) except FatalReplayGainError as e: raise ui.UserError( - u"Fatal replay gain error: {1}".format(e) + u"Fatal replay gain error: {0}".format(e) ) def handle_track(self, item, write): @@ -584,10 +584,10 @@ class ReplayGainPlugin(BeetsPlugin): if write: item.try_write() except ReplayGainError as e: - log.warn(u"ReplayGain error: {1}".format(e)) + log.warn(u"ReplayGain error: {0}".format(e)) except FatalReplayGainError as e: raise ui.UserError( - u"Fatal replay gain error: {1}".format(e) + u"Fatal replay gain error: {0}".format(e) ) def imported(self, session, task): diff --git a/docs/changelog.rst b/docs/changelog.rst index 7bd6552a7..773031a12 100644 --- a/docs/changelog.rst +++ b/docs/changelog.rst @@ -45,6 +45,7 @@ Fixes: regression a few releases ago, only track-level metadata was being updated. * On Windows, paths on network shares (UNC paths) no longer cause "invalid filename" errors. +* :doc:`/plugins/replaygain`: Fix crashes when attempting to log errors. .. _enum34: https://pypi.python.org/pypi/enum34 .. _enum: https://docs.python.org/3.4/library/enum.html