fix match() on RegexpQuery for non-string values

beets/library.py

@@ -452,6 +452,10 @@ class RegexpQuery(FieldQuery):
 
     def match(self, item):
         value = getattr(item, self.field) or ''
+        if value is None:
+            value = u''
+        elif not isinstance(value, basestring):
+            value = unicode(value)
         return self.regexp.search(value) is not None
 
 class BooleanQuery(MatchQuery):

docs/changelog.rst

@@ -12,6 +12,7 @@ Changelog
 * Fix album queries for ``artpath`` and other non-item fields.
 * Null values in the database can now be matched with the empty-string regular
   expression, ``^$``.
+* Regular expressions more reliably match non-string values.
 * :doc:`/plugins/fetchart`: Fix a bug where cover art filenames could lack
   a ``.jpg`` extension.
 * :doc:`/plugins/lyrics`: Fix an exception with non-ASCII lyrics.

test/test_query.py

@@ -302,6 +302,22 @@ class MemoryGetTest(unittest.TestCase, AssertsMixin):
         self.assert_matched(results, u'caf\xe9')
         self.assert_done(results)
 
+class MatchTest(unittest.TestCase):
+    def setUp(self):
+        self.item = _common.item()
+
+    def test_regex_match_positive(self):
+        q = beets.library.RegexpQuery('album', '^the album$')
+        self.assertTrue(q.match(self.item))
+
+    def test_regex_match_negative(self):
+        q = beets.library.RegexpQuery('album', '^album$')
+        self.assertFalse(q.match(self.item))
+
+    def test_regex_match_non_string_value(self):
+        q = beets.library.RegexpQuery('disc', '^6$')
+        self.assertTrue(q.match(self.item))
+
 class PathQueryTest(unittest.TestCase, AssertsMixin):
     def setUp(self):
         self.lib = beets.library.Library(':memory:')