From 77ce69fe77621c09c80a16205b29c298e1d08630 Mon Sep 17 00:00:00 2001 From: John Hamelink Date: Tue, 19 Jan 2021 22:05:34 +0000 Subject: [PATCH 1/2] Fixes #3834: This PR fixes a bug (#3834) where tracks which have already been fingerprinted do not return to be used by `beet submit` (part of the Chroma plugin). This results in submission errors, as the fingerprint is omitted from the resultant payload sent to acoustID. --- beetsplug/chroma.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/beetsplug/chroma.py b/beetsplug/chroma.py index 20d0f5479..91f2fe253 100644 --- a/beetsplug/chroma.py +++ b/beetsplug/chroma.py @@ -329,7 +329,7 @@ def fingerprint_item(log, item, write=False): else: log.info(u'{0}: using existing fingerprint', util.displayable_path(item.path)) - return item.acoustid_fingerprint + return item.acoustid_fingerprint else: log.info(u'{0}: fingerprinting', util.displayable_path(item.path)) From 64944a284e7abb103d0643172d3fb1c5ed6c8082 Mon Sep 17 00:00:00 2001 From: John Hamelink Date: Tue, 19 Jan 2021 22:11:34 +0000 Subject: [PATCH 2/2] Added changelog entry for #3834 fix --- docs/changelog.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/changelog.rst b/docs/changelog.rst index e99aa51d7..7e01d0e67 100644 --- a/docs/changelog.rst +++ b/docs/changelog.rst @@ -6,6 +6,8 @@ Changelog New features: +* Submitting acoustID information on tracks which already have a fingerprint + :bug:`3834` * conversion uses par_map to parallelize conversion jobs in python3 * Add ``title_case`` config option to lastgenre to make TitleCasing optional. * When config is printed with no available configuration a new message is printed.