From 54297dbab43616e961fe9d4016f134d9928ef821 Mon Sep 17 00:00:00 2001 From: test Date: Sun, 5 Nov 2017 12:04:40 +0100 Subject: [PATCH 1/3] Tentative fix for issue 2734: also check for RETAG --- beetsplug/fetchart.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/beetsplug/fetchart.py b/beetsplug/fetchart.py index a1153bd69..f0fef164e 100644 --- a/beetsplug/fetchart.py +++ b/beetsplug/fetchart.py @@ -783,7 +783,7 @@ class FetchArtPlugin(plugins.BeetsPlugin, RequestMixin): if task.choice_flag == importer.action.ASIS: # For as-is imports, don't search Web sources for art. local = True - elif task.choice_flag == importer.action.APPLY: + elif task.choice_flag in (importer.action.APPLY, importer.action.RETAG): # Search everywhere for art. local = False else: From 8544b3a830c3054a5e4d64ebba113a215aa308d4 Mon Sep 17 00:00:00 2001 From: test Date: Fri, 10 Nov 2017 13:46:26 +0100 Subject: [PATCH 2/3] Fix long line and add changelog entry --- beetsplug/fetchart.py | 3 ++- docs/changelog.rst | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/beetsplug/fetchart.py b/beetsplug/fetchart.py index f0fef164e..5fed59484 100644 --- a/beetsplug/fetchart.py +++ b/beetsplug/fetchart.py @@ -783,7 +783,8 @@ class FetchArtPlugin(plugins.BeetsPlugin, RequestMixin): if task.choice_flag == importer.action.ASIS: # For as-is imports, don't search Web sources for art. local = True - elif task.choice_flag in (importer.action.APPLY, importer.action.RETAG): + elif task.choice_flag in (importer.action.APPLY, + importer.action.RETAG): # Search everywhere for art. local = False else: diff --git a/docs/changelog.rst b/docs/changelog.rst index 07d2dff74..4eeadb2f6 100644 --- a/docs/changelog.rst +++ b/docs/changelog.rst @@ -65,6 +65,8 @@ Fixes: gstreamer backend. :bug:`2636` * :doc:`/plugins/scrub`: Handle errors when manipulating files using newer versions of Mutagen. :bug:`2716` +* :doc:`/plugins/fetchart`: Fix: don't skip running the fetchart plugin during import, when the + "Edit Candidates" option is used. :bug:`2734` For developers: From 842f6afd7f91c34c1a0a25c92d4602c9dd34c9e0 Mon Sep 17 00:00:00 2001 From: test Date: Fri, 10 Nov 2017 14:04:16 +0100 Subject: [PATCH 3/3] Fix indentation --- beetsplug/fetchart.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/beetsplug/fetchart.py b/beetsplug/fetchart.py index 5fed59484..8bee6e804 100644 --- a/beetsplug/fetchart.py +++ b/beetsplug/fetchart.py @@ -784,7 +784,7 @@ class FetchArtPlugin(plugins.BeetsPlugin, RequestMixin): # For as-is imports, don't search Web sources for art. local = True elif task.choice_flag in (importer.action.APPLY, - importer.action.RETAG): + importer.action.RETAG): # Search everywhere for art. local = False else: