From 8a1ce274210fc90aef1865721cfb433e24bcbb77 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=A0ar=C5=ABnas=20Nejus?= Date: Fri, 27 Sep 2024 22:57:20 +0100 Subject: [PATCH] lyrics: Do not write item unless lyrics have changed --- beetsplug/lyrics.py | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/beetsplug/lyrics.py b/beetsplug/lyrics.py index 5a1301039..5f733b7db 100644 --- a/beetsplug/lyrics.py +++ b/beetsplug/lyrics.py @@ -1077,15 +1077,13 @@ class LyricsPlugin(RequestHandler, plugins.BeetsPlugin): ) else: self.info("🔴 Lyrics not found: {}", item) - fallback = self.config["fallback"].get() - if fallback: - lyrics = fallback - else: - return - item.lyrics = lyrics - if write: - item.try_write() - item.store() + lyrics = self.config["fallback"].get() + + if lyrics not in {None, item.lyrics}: + item.lyrics = lyrics + if write: + item.try_write() + item.store() def get_lyrics(self, artist: str, title: str, *args) -> str | None: """Fetch lyrics, trying each source in turn. Return a string or