Backup_Repos/beets
1
0
Fork 0
mirror of https://github.com/beetbox/beets.git synced 2026-01-02 14:03:12 +01:00
Code Issues Projects Releases Wiki Activity

replaygain: remove albumgain setting

Browse source 
We now always calculate album gain when importing an album. This is "free" (no
performance cost) now and players are free to ignore the setting if they so
choose.
This commit is contained in:
Adrian Sampson 2012-10-17 20:11:20 -07:00
parent 3d68cf5deb
commit 83f3069d57
2 changed files with 12 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
beetsplug/replaygain.py
View file

@ -36,9 +36,9 @@ class ReplayGainError(Exception):
"""
def call(args):
"""Execute the command indicated by `args` (an array of strings) and
return the command's output. The stderr stream is ignored. If the command
exits abnormally, a ReplayGainError is raised.
"""Execute the command indicated by `args` (a list of strings) and
return the command's output. The stderr stream is ignored. If the
command exits abnormally, a ReplayGainError is raised.
"""
try:
with open(os.devnull, 'w') as devnull:
@ -62,8 +62,6 @@ class ReplayGainPlugin(BeetsPlugin):
'noclip', True, bool)
self.apply_gain = ui.config_val(config,'replaygain',
'apply_gain', False, bool)
self.albumgain = ui.config_val(config,'replaygain',
'albumgain', False, bool)
target_level = float(ui.config_val(config,'replaygain',
'targetlevel', DEFAULT_REFERENCE_LOUDNESS))
self.gain_offset = int(target_level - DEFAULT_REFERENCE_LOUDNESS)
@ -114,13 +112,13 @@ class ReplayGainPlugin(BeetsPlugin):
log.error("failed to calculate replaygain: %s ", e)
def requires_gain(self, mf):
def requires_gain(self, mf, album=False):
'''Does the gain need to be computed?'''
return self.overwrite or \
(not mf.rg_track_gain or not mf.rg_track_peak) or \
((not mf.rg_album_gain or not mf.rg_album_peak) and \
self.albumgain)
album)
def parse_tool_output(self, text):
@ -145,7 +143,7 @@ class ReplayGainPlugin(BeetsPlugin):
def reduce_gain_for_noclip(self, track_peaks, album_gain):
'''Reduce albumgain value until no song is clipped.
'''Reduce album gain value until no song is clipped.
No command switch give you the max no-clip in album mode.
So we consider the recommended gain and decrease it until no song is
clipped when applying the gain.
@ -167,7 +165,7 @@ class ReplayGainPlugin(BeetsPlugin):
# recalculation. This way, if any file among an album's tracks
# needs recalculation, we still get an accurate album gain
# value.
if all([not self.requires_gain(mf) for mf in media_files]):
if all([not self.requires_gain(mf, album) for mf in media_files]):
log.debug('replaygain: no gain to compute')
return

13
docs/plugins/replaygain.rst
View file

@ -45,14 +45,11 @@ for the plugin in your :doc:`/reference/config`, like so::
The target level can be modified to any target dB with the ``targetlevel``
option (default: 89 dB).
ReplayGain can normalize an entire album's loudness while allowing the dynamics
from song to song on the album to remain intact. This is called "album gain" and
is especially important for classical music albums with large loudness ranges.
"Track gain," in which each song is considered independently, is used by
default. To override this, use the ``albumgain`` option::
[replaygain]
albumgain: yes
When analyzing albums, this plugin calculates both an "album gain" alongside
individual track gains. Album gain normalizes an entire album's loudness while
allowing the dynamics from song to song on the album to remain intact. This is
especially important for classical music albums with large loudness ranges.
Players can choose which gain (track or album) to honor.
If you use a player that does not support ReplayGain specifications, you can
force the volume normalization by applying the gain to the file via the