Backup_Repos/beets
1
0
Fork 0
mirror of https://github.com/beetbox/beets.git synced 2026-02-08 08:25:23 +01:00
Code Issues Projects Releases Wiki Activity

Refactor parsing language and script

Browse source
This commit is contained in:
Šarūnas Nejus 2026-01-25 01:31:13 +00:00
parent 99afdd3c04
commit 7d2dddcca5
No known key found for this signature in database
3 changed files with 21 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
beetsplug/musicbrainz.py
View file

@ -596,6 +596,8 @@ class MusicBrainzPlugin(MusicBrainzAPIMixin, MetadataSourcePlugin):
data_url=urljoin(BASE_URL, f"release/{release['id']}"),
barcode=release.get("barcode"),
genre=genre if (genre := self._parse_genre(release)) else None,
script=release["text_representation"]["script"],
language=release["text_representation"]["language"],
**self._parse_release_group(release["release_group"]),
**self._parse_label_infos(release["label_info"]),
**self._parse_external_ids(release.get("url_relations", [])),
@ -621,12 +623,6 @@ class MusicBrainzPlugin(MusicBrainzAPIMixin, MetadataSourcePlugin):
)
)
# Text representation data.
if release.get("text_representation"):
rep = release["text_representation"]
info.script = rep.get("script")
info.language = rep.get("language")
# Media (format).
if release["media"]:
# If all media are the same, use that medium name

5
test/plugins/factories/musicbrainz.py
View file

@ -144,3 +144,8 @@ class LabelInfoFactory(factory.DictFactory):
lambda o: f"{o.label['name'][:3].upper()}123"
)
label = factory.SubFactory(LabelFactory)
class TextRepresentationFactory(factory.DictFactory):
language = "eng"
script = "Latn"

21
test/plugins/test_musicbrainz.py
View file

@ -72,6 +72,10 @@ def label_info_factory(**kwargs) -> mb.LabelInfo:
return factories.LabelInfoFactory.build(**kwargs)
def text_representation_factory(**kwargs) -> mb.TextRepresentation:
return factories.TextRepresentationFactory.build(**kwargs)
class MusicBrainzTestCase(BeetsTestCase):
def setUp(self):
super().setUp()
@ -100,10 +104,7 @@ class MusicBrainzTestCase(BeetsTestCase):
"genres": [genre_factory()],
"tags": [tag_factory()],
"label_info": [label_info_factory()],
"text_representation": {
"script": "SCRIPT",
"language": "LANGUAGE",
},
"text_representation": text_representation_factory(),
"country": "COUNTRY",
"status": "STATUS",
"barcode": "BARCODE",
@ -375,8 +376,8 @@ class MBAlbumInfoTest(MusicBrainzTestCase):
def test_parse_textrepr(self):
release = self._make_release()
d = self.mb.album_info(release)
assert d.script == "SCRIPT"
assert d.language == "LANGUAGE"
assert d.script == "Latn"
assert d.language == "eng"
def test_parse_country(self):
release = self._make_release()
@ -421,7 +422,7 @@ class MBAlbumInfoTest(MusicBrainzTestCase):
def test_missing_language(self):
release = self._make_release()
del release["text_representation"]["language"]
release["text_representation"]["language"] = None
d = self.mb.album_info(release)
assert d.language is None
@ -813,6 +814,7 @@ class MBLibraryTest(MusicBrainzTestCase):
"artist_credit": [artist_credit_factory()],
"release_group": release_group_factory(),
"label_info": [label_info_factory()],
"text_representation": text_representation_factory(),
"release_relations": [
{
"type": "transl-tracklisting",
@ -846,6 +848,7 @@ class MBLibraryTest(MusicBrainzTestCase):
"release_group": release_group_factory(),
"country": "COUNTRY",
"label_info": [label_info_factory()],
"text_representation": text_representation_factory(),
},
]
@ -880,6 +883,7 @@ class MBLibraryTest(MusicBrainzTestCase):
"artist_credit": [artist_credit_factory()],
"release_group": release_group_factory(),
"label_info": [label_info_factory()],
"text_representation": text_representation_factory(),
}
]
@ -914,6 +918,7 @@ class MBLibraryTest(MusicBrainzTestCase):
"artist_credit": [artist_credit_factory()],
"release_group": release_group_factory(),
"label_info": [label_info_factory()],
"text_representation": text_representation_factory(),
}
]
@ -948,6 +953,7 @@ class MBLibraryTest(MusicBrainzTestCase):
"artist_credit": [artist_credit_factory()],
"release_group": release_group_factory(),
"label_info": [label_info_factory()],
"text_representation": text_representation_factory(),
"release_relations": [
{
"type": "remaster",
@ -1054,6 +1060,7 @@ class TestMusicBrainzPlugin(PluginMixin):
"artist_credit": [artist_credit_factory()],
"release_group": release_group_factory(),
"label_info": [label_info_factory()],
"text_representation": text_representation_factory(),
},
)
candidates = list(mb.candidates([], "hello", "there", False))