+
+ {{:: 'cloud_flare_always_on_short_message' | i18n }}
+
Check @genius for updates. We'll have things fixed soon. +
+
+
+
+
+Check @genius for updates. We'll have things fixed soon. +
+
+
+
+
+
+
+
+
+ GENIUS
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ 
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ Beets is awesome!
+
+
+
+
+
+
+
+ More on Genius
+
+
+
+
+
+
+
+
+
+
+
+
+ Denzel Curry’s ZillaKami Collaboration “EVIL TWIN” Is His Latest Song To Flip A Wu-Tang Clan Classic
+
+
+
+
+
+
+
+
+ Denzel Curry Links Up With Kenny Beats To Drop A Freestyle In ‘The Cave’
+
+
+
+
+
+ Miley Cyrus References Wu-Tang Clan’s Biggest Hit On “D.R.E.A.M. (Drugs Rule Everything Around Me)”
+
+
+
+
+
+
+
+
+
+
+
+
+ + About “C.R.E.A.M.” +
+ + +
+
+
+ Arguably one of the most iconic songs in hip-hop, the underlying idea of “C.R.E.A.M.” is found in its title—cash rules everything. The timeless piano riffs and background vocals come from a chopped up sample of The Charmels‘ 1967 record, “As Long As I’ve Got You,” that make up the entire track.
+ +Although it was released as an official single in 1994, “C.R.E.A.M.” was first recorded in 1991, around the same time as RZA’s assault case, and featured himself and Ghostface Killah. The track went through several revisions and was later re-recorded by Raekwon and Inspectah Deck in 1993—an early title of the song was “Lifestyles of the Mega-Rich.”
+ +In 2017, RZA explained to Power 106 how the final version of the track came together:
+ ++ +Once we got to the studio, I decided that this track had to be on the Wu-Tang album. I reminded Rae and Deck of their verses—their verses were long. […] Method Man, the master of hooks at the time, came in with this hook right here: ‘cash rules everything around me, cream, get the money.’ Once he added that element, I knew it was going to be a smash.
Since its release, the song and chorus have been referenced countless times by several artists. It has also been featured in movies such as Eminem’s 8 Mile and the N.W.A biopic, Straight Outta Compton.
+
+
+
+
+
+
+ -
+
+
-
+ ++ +
What has RZA said about the song?
++ ++ + +
+
+
+ -
+ ++ +
What has Raekwon said about the song?
+++ + ++
+ + +‘C.R.E.A.M.’ did a lot for my career personally. It gave me an opportunity to revisit the times where that cream meant that much to us. So, yeah, when I think of this record it just automatically puts me back into ‘87/’88 where we were standing in front of the building. It’s cold outside. We didn’t care. We’re out there, all black on trying to make dollars. Just trying to make some money and trying to eat. Survive.
+ +This song, I remember writing to the beat a long time ago before we actually came out. That beat is old. That was probably like a ‘89 beat. RZA had it that long because he had a bunch of breaks. He had all kind of things and he was making beats back then, but we was just picking and that beat happened to always sit around and I would be like, ‘I want that beat, so don’t give that beat to nobody.’ And he kept his word and let me have it.
+ +Meth came up with the hook but our dude named Raider Ruckus, this was like Meth’s homeboy back then, like they was real close, he came up with the phrase ‘cash rules everything around me.’ So when he showed Meth what it was and was like, ‘Cash rules everything around me,’ Meth was like, ‘Word, you right!’ And turned it into a movie, and I came in later that day and heard it and co-signed it.
+
+
+
+ -
+ ++ +
What has U-God said about the song?
+++ + +
+ +“C.R.E.A.M.” is a true song. Everything Inspectah Deck and Raekwon said is 100 percent true. Not one line in that entire song is a lie, or even a slight exaggeration. Deck did sell base, and he did go to jail at the age of fifteen. Rae was sticking up white boys on ball courts, rocking the same damn ’Lo sweater. And of “course, Meth on the hook was like butter on the popcorn. Meth knew the hard times, too, being out there smoking woolies and pumping crack, etc. That raspy shit he was kicking just echoed in everyone’s head long after the song was done playing.
The realism on “C.R.E.A.M.” is what resonates with so many people all over the world. People everywhere know that sentiment of being slaves to the dollar. Cash is king, and we are its lowly subjects. That’s pretty much the case in every nation around the world, the desperation to put your life and your freedom on the line to make a couple dollars. Whether you’re working, stripping, hustling, or slinging, whether you’re a business owner or homeless, cash rules everything around us.Source: Raw:My Journey into Wu-Tang
+
+
+
+ -
+ ++ +
What songs were sampled on the beat for “C.R.E.A.M.?”
+++ + +The vocals and background sample that can be heard on the song’s intro were taken taken from The Charmels’ 1967 song “As Long as I’ve Got You”:
+ + + +The classic keys sample that can be heard throughout the beat was also taken from the previously mentioned song:
+ + +
+
+
+ -
+ ++ +
What has Method Man said about the song?
+++ + +Meth told Complex,
+ ++
+‘C.R.E.A.M.’ was the one that really put us on the map if you wanna be technical. I wasn’t there when they recorded ‘C.R.E.A.M.’ I came in after the fact. RZA was like, ‘Put a hook on this song’ and I put a hook on it. That’s how it always went. I liked doing hooks.
+ +The hook for that was done by my man Raider Ruckus. We used to work at the Statue of Liberty and when we were coming home we used to come up with all these made-up words that were acronyms.
+ +We had words like ‘BIBWAM’ which meant, ‘Bitches Is Busted Without A Man’ and all this other crazy shit. Raider Ruckus was so ill with the way he put the words together. We would call money ‘cream’ so he took each letter and made a word out of it and killed it the way he did it.
+ +Something like that had never been done before as far as a hook or even a way of speaking. This is just showing and proving that we paid attention in class when we was kids. You can’t do shit like that unless you got a brain in your fucking head! You got to have some level of intelligence to do something like that.
+ +The best acronym for a word that I heard was ‘P.R.O.J.E.C.T.S.’ by Killah Priest. He said ‘People Relying On Just Enough Cash To Survive.’ And he’s the one that came up with ‘Basic Instructions Before Leaving Earth,’ the acronym for B.I.B.L.E. This ain’t no fluke shit man.
+ +There’s a reason you got millions upon millions of fucking kids running around with Wu-Tang tattoos. You don’t just put something on your body permanently unless it’s official. At that time, when you’re coming out brand new and representing where you come from, everybody from that area wants you to win because they win. That’s what it was like for us.
+ +We were the only dudes from Staten Island doing it so everybody from Staten Island wanted us to win. Not just dudes from Staten Island, but dudes from Brooklyn too because they had peoples in the group too. Then it was just grimy niggas who loved to see real shit, saying, ‘We riding with them Wu-Tang niggas. Fuck all that shiny suit shit!’ That ain’t no take on Puff, a lot of niggas was wearing suits and shit man, but that ain’t us.
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ 
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ 1.
+
+
+
+ Bring Da Ruckus
+
+
+
+
+
+
+
+
+
+
+ 2.
+
+
+
+ Shame On A Nigga
+
+
+
+
+
+
+
+
+
+
+ 3.
+
+
+
+ Clan in Da Front
+
+
+
+
+
+
+
+
+
+
+ 4.
+
+
+
+ Wu-Tang: 7th Chamber
+
+
+
+
+
+
+
+
+
+
+ 5.
+
+
+
+ Can It Be All So Simple / Intermission
+
+
+
+
+
+
+
+
+
+
+ 6.
+
+
+
+ Da Mystery of Chessboxin’
+
+
+
+
+
+
+
+
+
+
+ 7.
+
+
+
+ Wu-Tang Clan Ain’t Nuthing ta Fuck Wit
+
+
+
+
+
+
+
+
+
+
+ 8.
+
+
+
+ C.R.E.A.M.
+
+
+
+
+
+
+
+
+
+
+ 9.
+
+
+
+ Method Man
+
+
+
+
+
+
+
+
+
+
+ 10.
+
+
+
+ Protect Ya Neck
+
+
+
+
+
+
+
+
+
+
+ 11.
+
+
+
+ Tearz
+
+
+
+
+
+
+
+
+
+
+ 12.
+
+
+
+ Wu-Tang: 7th Chamber - Pt. II
+
+
+
+
+
+
+
+
+
+
+ 13.
+
+
+
+ Conclusion
+
+
+
+
+
+ 
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ 
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ SONG Lyrics
+
+
+
+ !!!! MISSING LYRICS HERE !!!
+
+
+
+
+
+ More on g-example
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
diff --git a/test/test_autotag.py b/test/test_autotag.py
index 28b7fd209..febd1641d 100644
--- a/test/test_autotag.py
+++ b/test/test_autotag.py
@@ -18,7 +18,6 @@
from __future__ import division, absolute_import, print_function
import re
-import copy
import unittest
from test import _common
@@ -91,7 +90,10 @@ class PluralityTest(_common.TestCase):
for i in range(5)]
likelies, _ = match.current_metadata(items)
for f in fields:
- self.assertEqual(likelies[f], '%s_1' % f)
+ if isinstance(likelies[f], int):
+ self.assertEqual(likelies[f], 0)
+ else:
+ self.assertEqual(likelies[f], '%s_1' % f)
def _make_item(title, track, artist=u'some artist'):
@@ -103,9 +105,12 @@ def _make_item(title, track, artist=u'some artist'):
def _make_trackinfo():
return [
- TrackInfo(u'one', None, artist=u'some artist', length=1, index=1),
- TrackInfo(u'two', None, artist=u'some artist', length=1, index=2),
- TrackInfo(u'three', None, artist=u'some artist', length=1, index=3),
+ TrackInfo(title=u'one', track_id=None, artist=u'some artist',
+ length=1, index=1),
+ TrackInfo(title=u'two', track_id=None, artist=u'some artist',
+ length=1, index=2),
+ TrackInfo(title=u'three', track_id=None, artist=u'some artist',
+ length=1, index=3),
]
@@ -345,9 +350,7 @@ class AlbumDistanceTest(_common.TestCase):
artist=u'some artist',
album=u'some album',
tracks=_make_trackinfo(),
- va=False,
- album_id=None,
- artist_id=None,
+ va=False
)
self.assertEqual(self._dist(items, info), 0)
@@ -359,9 +362,7 @@ class AlbumDistanceTest(_common.TestCase):
artist=u'some artist',
album=u'some album',
tracks=_make_trackinfo(),
- va=False,
- album_id=None,
- artist_id=None,
+ va=False
)
dist = self._dist(items, info)
self.assertNotEqual(dist, 0)
@@ -377,9 +378,7 @@ class AlbumDistanceTest(_common.TestCase):
artist=u'someone else',
album=u'some album',
tracks=_make_trackinfo(),
- va=False,
- album_id=None,
- artist_id=None,
+ va=False
)
self.assertNotEqual(self._dist(items, info), 0)
@@ -392,9 +391,7 @@ class AlbumDistanceTest(_common.TestCase):
artist=u'should be ignored',
album=u'some album',
tracks=_make_trackinfo(),
- va=True,
- album_id=None,
- artist_id=None,
+ va=True
)
self.assertEqual(self._dist(items, info), 0)
@@ -408,9 +405,7 @@ class AlbumDistanceTest(_common.TestCase):
artist=u'should be ignored',
album=u'some album',
tracks=_make_trackinfo(),
- va=True,
- album_id=None,
- artist_id=None,
+ va=True
)
info.tracks[0].artist = None
info.tracks[1].artist = None
@@ -426,9 +421,7 @@ class AlbumDistanceTest(_common.TestCase):
artist=u'some artist',
album=u'some album',
tracks=_make_trackinfo(),
- va=True,
- album_id=None,
- artist_id=None,
+ va=True
)
self.assertNotEqual(self._dist(items, info), 0)
@@ -441,9 +434,7 @@ class AlbumDistanceTest(_common.TestCase):
artist=u'some artist',
album=u'some album',
tracks=_make_trackinfo(),
- va=False,
- album_id=None,
- artist_id=None,
+ va=False
)
dist = self._dist(items, info)
self.assertTrue(0 < dist < 0.2)
@@ -457,9 +448,7 @@ class AlbumDistanceTest(_common.TestCase):
artist=u'some artist',
album=u'some album',
tracks=_make_trackinfo(),
- va=False,
- album_id=None,
- artist_id=None,
+ va=False
)
info.tracks[0].medium_index = 1
info.tracks[1].medium_index = 2
@@ -476,9 +465,7 @@ class AlbumDistanceTest(_common.TestCase):
artist=u'some artist',
album=u'some album',
tracks=_make_trackinfo(),
- va=False,
- album_id=None,
- artist_id=None,
+ va=False
)
info.tracks[0].medium_index = 1
info.tracks[1].medium_index = 2
@@ -500,9 +487,9 @@ class AssignmentTest(unittest.TestCase):
items.append(self.item(u'three', 2))
items.append(self.item(u'two', 3))
trackinfo = []
- trackinfo.append(TrackInfo(u'one', None))
- trackinfo.append(TrackInfo(u'two', None))
- trackinfo.append(TrackInfo(u'three', None))
+ trackinfo.append(TrackInfo(title=u'one'))
+ trackinfo.append(TrackInfo(title=u'two'))
+ trackinfo.append(TrackInfo(title=u'three'))
mapping, extra_items, extra_tracks = \
match.assign_items(items, trackinfo)
self.assertEqual(extra_items, [])
@@ -519,9 +506,9 @@ class AssignmentTest(unittest.TestCase):
items.append(self.item(u'three', 1))
items.append(self.item(u'two', 1))
trackinfo = []
- trackinfo.append(TrackInfo(u'one', None))
- trackinfo.append(TrackInfo(u'two', None))
- trackinfo.append(TrackInfo(u'three', None))
+ trackinfo.append(TrackInfo(title=u'one'))
+ trackinfo.append(TrackInfo(title=u'two'))
+ trackinfo.append(TrackInfo(title=u'three'))
mapping, extra_items, extra_tracks = \
match.assign_items(items, trackinfo)
self.assertEqual(extra_items, [])
@@ -537,9 +524,9 @@ class AssignmentTest(unittest.TestCase):
items.append(self.item(u'one', 1))
items.append(self.item(u'three', 3))
trackinfo = []
- trackinfo.append(TrackInfo(u'one', None))
- trackinfo.append(TrackInfo(u'two', None))
- trackinfo.append(TrackInfo(u'three', None))
+ trackinfo.append(TrackInfo(title=u'one'))
+ trackinfo.append(TrackInfo(title=u'two'))
+ trackinfo.append(TrackInfo(title=u'three'))
mapping, extra_items, extra_tracks = \
match.assign_items(items, trackinfo)
self.assertEqual(extra_items, [])
@@ -555,8 +542,8 @@ class AssignmentTest(unittest.TestCase):
items.append(self.item(u'two', 2))
items.append(self.item(u'three', 3))
trackinfo = []
- trackinfo.append(TrackInfo(u'one', None))
- trackinfo.append(TrackInfo(u'three', None))
+ trackinfo.append(TrackInfo(title=u'one'))
+ trackinfo.append(TrackInfo(title=u'three'))
mapping, extra_items, extra_tracks = \
match.assign_items(items, trackinfo)
self.assertEqual(extra_items, [items[1]])
@@ -592,7 +579,8 @@ class AssignmentTest(unittest.TestCase):
items.append(item(12, 186.45916150485752))
def info(index, title, length):
- return TrackInfo(title, None, length=length, index=index)
+ return TrackInfo(title=title, length=length,
+ index=index)
trackinfo = []
trackinfo.append(info(1, u'Alone', 238.893))
trackinfo.append(info(2, u'The Woman in You', 341.44))
@@ -635,8 +623,8 @@ class ApplyTest(_common.TestCase, ApplyTestUtil):
self.items.append(Item({}))
trackinfo = []
trackinfo.append(TrackInfo(
- u'oneNew',
- u'dfa939ec-118c-4d0f-84a0-60f3d1e6522c',
+ title=u'oneNew',
+ track_id=u'dfa939ec-118c-4d0f-84a0-60f3d1e6522c',
medium=1,
medium_index=1,
medium_total=1,
@@ -645,8 +633,8 @@ class ApplyTest(_common.TestCase, ApplyTestUtil):
artist_sort='trackArtistSort',
))
trackinfo.append(TrackInfo(
- u'twoNew',
- u'40130ed1-a27c-42fd-a328-1ebefb6caef4',
+ title=u'twoNew',
+ track_id=u'40130ed1-a27c-42fd-a328-1ebefb6caef4',
medium=2,
medium_index=1,
index=2,
@@ -746,13 +734,13 @@ class ApplyTest(_common.TestCase, ApplyTestUtil):
self.assertEqual(self.items[1].albumtype, 'album')
def test_album_artist_overrides_empty_track_artist(self):
- my_info = copy.deepcopy(self.info)
+ my_info = self.info.copy()
self._apply(info=my_info)
self.assertEqual(self.items[0].artist, 'artistNew')
self.assertEqual(self.items[1].artist, 'artistNew')
def test_album_artist_overridden_by_nonempty_track_artist(self):
- my_info = copy.deepcopy(self.info)
+ my_info = self.info.copy()
my_info.tracks[0].artist = 'artist1!'
my_info.tracks[1].artist = 'artist2!'
self._apply(info=my_info)
@@ -774,7 +762,7 @@ class ApplyTest(_common.TestCase, ApplyTestUtil):
self.assertEqual(self.items[1].artist_sort, 'albumArtistSort')
def test_full_date_applied(self):
- my_info = copy.deepcopy(self.info)
+ my_info = self.info.copy()
my_info.year = 2013
my_info.month = 12
my_info.day = 18
@@ -789,7 +777,7 @@ class ApplyTest(_common.TestCase, ApplyTestUtil):
self.items.append(Item(year=1, month=2, day=3))
self.items.append(Item(year=4, month=5, day=6))
- my_info = copy.deepcopy(self.info)
+ my_info = self.info.copy()
my_info.year = 2013
self._apply(info=my_info)
@@ -809,7 +797,7 @@ class ApplyTest(_common.TestCase, ApplyTestUtil):
self.assertEqual(self.items[0].day, 3)
def test_data_source_applied(self):
- my_info = copy.deepcopy(self.info)
+ my_info = self.info.copy()
my_info.data_source = 'MusicBrainz'
self._apply(info=my_info)
@@ -825,15 +813,15 @@ class ApplyCompilationTest(_common.TestCase, ApplyTestUtil):
self.items.append(Item({}))
trackinfo = []
trackinfo.append(TrackInfo(
- u'oneNew',
- u'dfa939ec-118c-4d0f-84a0-60f3d1e6522c',
+ title=u'oneNew',
+ track_id=u'dfa939ec-118c-4d0f-84a0-60f3d1e6522c',
artist=u'artistOneNew',
artist_id=u'a05686fc-9db2-4c23-b99e-77f5db3e5282',
index=1,
))
trackinfo.append(TrackInfo(
- u'twoNew',
- u'40130ed1-a27c-42fd-a328-1ebefb6caef4',
+ title=u'twoNew',
+ track_id=u'40130ed1-a27c-42fd-a328-1ebefb6caef4',
artist=u'artistTwoNew',
artist_id=u'80b3cf5e-18fe-4c59-98c7-e5bb87210710',
index=2,
@@ -871,7 +859,7 @@ class ApplyCompilationTest(_common.TestCase, ApplyTestUtil):
self.assertFalse(self.items[1].comp)
def test_va_flag_sets_comp(self):
- va_info = copy.deepcopy(self.info)
+ va_info = self.info.copy()
va_info.va = True
self._apply(info=va_info)
self.assertTrue(self.items[0].comp)
diff --git a/test/test_convert.py b/test/test_convert.py
index 33bdb3b24..b8cd56741 100644
--- a/test/test_convert.py
+++ b/test/test_convert.py
@@ -15,6 +15,7 @@
from __future__ import division, absolute_import, print_function
+import fnmatch
import sys
import re
import os.path
@@ -121,6 +122,15 @@ class ImportConvertTest(unittest.TestCase, TestHelper):
self.assertIsNotNone(item)
self.assertTrue(os.path.isfile(item.path))
+ def test_delete_originals(self):
+ self.config['convert']['delete_originals'] = True
+ self.importer.run()
+ for path in self.importer.paths:
+ for root, dirnames, filenames in os.walk(path):
+ self.assertTrue(len(fnmatch.filter(filenames, '*.mp3')) == 0,
+ u'Non-empty import directory {0}'
+ .format(util.displayable_path(path)))
+
class ConvertCommand(object):
"""A mixin providing a utility method to run the `convert`command
diff --git a/test/test_dbcore.py b/test/test_dbcore.py
index 9bf78de67..0d40896da 100644
--- a/test/test_dbcore.py
+++ b/test/test_dbcore.py
@@ -53,6 +53,7 @@ class ModelFixture1(dbcore.Model):
_fields = {
'id': dbcore.types.PRIMARY_ID,
'field_one': dbcore.types.INTEGER,
+ 'field_two': dbcore.types.STRING,
}
_types = {
'some_float_field': dbcore.types.FLOAT,
@@ -355,7 +356,7 @@ class ModelTest(unittest.TestCase):
def test_items(self):
model = ModelFixture1(self.db)
model.id = 5
- self.assertEqual({('id', 5), ('field_one', 0)},
+ self.assertEqual({('id', 5), ('field_one', 0), ('field_two', '')},
set(model.items()))
def test_delete_internal_field(self):
@@ -370,10 +371,28 @@ class ModelTest(unittest.TestCase):
class FormatTest(unittest.TestCase):
- def test_format_fixed_field(self):
+ def test_format_fixed_field_integer(self):
model = ModelFixture1()
- model.field_one = u'caf\xe9'
+ model.field_one = 155
value = model.formatted().get('field_one')
+ self.assertEqual(value, u'155')
+
+ def test_format_fixed_field_integer_normalized(self):
+ """The normalize method of the Integer class rounds floats
+ """
+ model = ModelFixture1()
+ model.field_one = 142.432
+ value = model.formatted().get('field_one')
+ self.assertEqual(value, u'142')
+
+ model.field_one = 142.863
+ value = model.formatted().get('field_one')
+ self.assertEqual(value, u'143')
+
+ def test_format_fixed_field_string(self):
+ model = ModelFixture1()
+ model.field_two = u'caf\xe9'
+ value = model.formatted().get('field_two')
self.assertEqual(value, u'caf\xe9')
def test_format_flex_field(self):
diff --git a/test/test_export.py b/test/test_export.py
index 757212a38..779e74423 100644
--- a/test/test_export.py
+++ b/test/test_export.py
@@ -23,7 +23,7 @@ from test.helper import TestHelper
import re # used to test csv format
import json
from xml.etree.ElementTree import Element
-import xml.etree.ElementTree as ET
+from xml.etree import ElementTree
class ExportPluginTest(unittest.TestCase, TestHelper):
@@ -85,7 +85,7 @@ class ExportPluginTest(unittest.TestCase, TestHelper):
format_type='xml',
artist=item1.artist
)
- library = ET.fromstring(out)
+ library = ElementTree.fromstring(out)
self.assertIsInstance(library, Element)
for track in library[0]:
for details in track:
diff --git a/test/test_files.py b/test/test_files.py
index f31779672..13a8b4407 100644
--- a/test/test_files.py
+++ b/test/test_files.py
@@ -102,6 +102,25 @@ class MoveTest(_common.TestCase):
self.i.move()
self.assertEqual(self.i.path, old_path)
+ def test_move_file_with_colon(self):
+ self.i.artist = u'C:DOS'
+ self.i.move()
+ self.assertIn('C_DOS', self.i.path.decode())
+
+ def test_move_file_with_multiple_colons(self):
+ print(beets.config['replace'])
+ self.i.artist = u'COM:DOS'
+ self.i.move()
+ self.assertIn('COM_DOS', self.i.path.decode())
+
+ def test_move_file_with_colon_alt_separator(self):
+ old = beets.config['drive_sep_replace']
+ beets.config["drive_sep_replace"] = '0'
+ self.i.artist = u'C:DOS'
+ self.i.move()
+ self.assertIn('C0DOS', self.i.path.decode())
+ beets.config["drive_sep_replace"] = old
+
def test_read_only_file_copied_writable(self):
# Make the source file read-only.
os.chmod(self.path, 0o444)
diff --git a/test/test_importer.py b/test/test_importer.py
index 8f637a077..3418d4628 100644
--- a/test/test_importer.py
+++ b/test/test_importer.py
@@ -79,7 +79,7 @@ class AutotagStub(object):
autotag.mb.album_for_id = self.mb_album_for_id
autotag.mb.track_for_id = self.mb_track_for_id
- def match_album(self, albumartist, album, tracks):
+ def match_album(self, albumartist, album, tracks, extra_tags):
if self.matching == self.IDENT:
yield self._make_album_match(albumartist, album, tracks)
diff --git a/test/test_lyrics.py b/test/test_lyrics.py
index f7ea538e2..e0ec1e548 100644
--- a/test/test_lyrics.py
+++ b/test/test_lyrics.py
@@ -17,28 +17,28 @@
from __future__ import absolute_import, division, print_function
+import itertools
+from io import open
import os
import re
import six
import sys
import unittest
-from mock import patch
-from test import _common
+import confuse
+from mock import MagicMock, patch
from beets import logging
from beets.library import Item
from beets.util import bytestring_path
-import confuse
-
from beetsplug import lyrics
-
-from mock import MagicMock
+from test import _common
log = logging.getLogger('beets.test_lyrics')
raw_backend = lyrics.Backend({}, log)
google = lyrics.Google(MagicMock(), log)
+genius = lyrics.Genius(MagicMock(), log)
class LyricsPluginTest(unittest.TestCase):
@@ -94,6 +94,27 @@ class LyricsPluginTest(unittest.TestCase):
self.assertEqual(('Alice and Bob', ['song']),
list(lyrics.search_pairs(item))[0])
+ def test_search_artist_sort(self):
+ item = Item(artist='CHVRCHΞS', title='song', artist_sort='CHVRCHES')
+ self.assertIn(('CHVRCHΞS', ['song']),
+ lyrics.search_pairs(item))
+ self.assertIn(('CHVRCHES', ['song']),
+ lyrics.search_pairs(item))
+
+ # Make sure that the original artist name is still the first entry
+ self.assertEqual(('CHVRCHΞS', ['song']),
+ list(lyrics.search_pairs(item))[0])
+
+ item = Item(artist='横山克', title='song', artist_sort='Masaru Yokoyama')
+ self.assertIn(('横山克', ['song']),
+ lyrics.search_pairs(item))
+ self.assertIn(('Masaru Yokoyama', ['song']),
+ lyrics.search_pairs(item))
+
+ # Make sure that the original artist name is still the first entry
+ self.assertEqual(('横山克', ['song']),
+ list(lyrics.search_pairs(item))[0])
+
def test_search_pairs_multi_titles(self):
item = Item(title='1 / 2', artist='A')
self.assertIn(('A', ['1 / 2']), lyrics.search_pairs(item))
@@ -209,7 +230,7 @@ class MockFetchUrl(object):
def __call__(self, url, filename=None):
self.fetched = url
fn = url_to_filename(url)
- with open(fn, 'r') as f:
+ with open(fn, 'r', encoding="utf8") as f:
content = f.read()
return content
@@ -248,8 +269,8 @@ class LyricsPluginSourcesTest(LyricsGoogleBaseTest):
DEFAULT_SOURCES = [
dict(DEFAULT_SONG, backend=lyrics.LyricsWiki),
- dict(artist=u'Santana', title=u'Black magic woman',
- backend=lyrics.MusiXmatch),
+ # dict(artist=u'Santana', title=u'Black magic woman',
+ # backend=lyrics.MusiXmatch),
dict(DEFAULT_SONG, backend=lyrics.Genius),
]
@@ -263,9 +284,9 @@ class LyricsPluginSourcesTest(LyricsGoogleBaseTest):
dict(DEFAULT_SONG,
url=u'http://www.chartlyrics.com',
path=u'/_LsLsZ7P4EK-F-LD4dJgDQ/Lady+Madonna.aspx'),
- dict(DEFAULT_SONG,
- url=u'http://www.elyricsworld.com',
- path=u'/lady_madonna_lyrics_beatles.html'),
+ # dict(DEFAULT_SONG,
+ # url=u'http://www.elyricsworld.com',
+ # path=u'/lady_madonna_lyrics_beatles.html'),
dict(url=u'http://www.lacoccinelle.net',
artist=u'Jacques Brel', title=u"Amsterdam",
path=u'/paroles-officielles/275679.html'),
@@ -282,11 +303,11 @@ class LyricsPluginSourcesTest(LyricsGoogleBaseTest):
dict(url=u'http://www.lyricsontop.com',
artist=u'Amy Winehouse', title=u"Jazz'n'blues",
path=u'/amy-winehouse-songs/jazz-n-blues-lyrics.html'),
- dict(DEFAULT_SONG,
- url='http://www.metrolyrics.com/',
- path='lady-madonna-lyrics-beatles.html'),
- dict(url='http://www.musica.com/', path='letras.asp?letra=2738',
- artist=u'Santana', title=u'Black magic woman'),
+ # dict(DEFAULT_SONG,
+ # url='http://www.metrolyrics.com/',
+ # path='lady-madonna-lyrics-beatles.html'),
+ # dict(url='http://www.musica.com/', path='letras.asp?letra=2738',
+ # artist=u'Santana', title=u'Black magic woman'),
dict(url=u'http://www.paroles.net/',
artist=u'Lilly Wood & the prick', title=u"Hey it's ok",
path=u'lilly-wood-the-prick/paroles-hey-it-s-ok'),
@@ -302,23 +323,28 @@ class LyricsPluginSourcesTest(LyricsGoogleBaseTest):
LyricsGoogleBaseTest.setUp(self)
self.plugin = lyrics.LyricsPlugin()
- @unittest.skipUnless(os.environ.get(
- 'BEETS_TEST_LYRICS_SOURCES', '0') == '1',
- 'lyrics sources testing not enabled')
+ @unittest.skipUnless(
+ os.environ.get('INTEGRATION_TEST', '0') == '1',
+ 'integration testing not enabled')
def test_backend_sources_ok(self):
"""Test default backends with songs known to exist in respective databases.
"""
errors = []
- for s in self.DEFAULT_SOURCES:
+ # GitHub actions seems to be on a Cloudflare blacklist, so we can't
+ # contact genius.
+ sources = [s for s in self.DEFAULT_SOURCES if
+ s['backend'] != lyrics.Genius or
+ os.environ.get('GITHUB_ACTIONS') != 'true']
+ for s in sources:
res = s['backend'](self.plugin.config, self.plugin._log).fetch(
s['artist'], s['title'])
if not is_lyrics_content_ok(s['title'], res):
errors.append(s['backend'].__name__)
self.assertFalse(errors)
- @unittest.skipUnless(os.environ.get(
- 'BEETS_TEST_LYRICS_SOURCES', '0') == '1',
- 'lyrics sources testing not enabled')
+ @unittest.skipUnless(
+ os.environ.get('INTEGRATION_TEST', '0') == '1',
+ 'integration testing not enabled')
def test_google_sources_ok(self):
"""Test if lyrics present on websites registered in beets google custom
search engine are correctly scraped.
@@ -395,24 +421,133 @@ class LyricsGooglePluginMachineryTest(LyricsGoogleBaseTest):
google.is_page_candidate(url, url_title, s['title'], u'Sunn O)))')
+# test Genius backend
+
+class GeniusBaseTest(unittest.TestCase):
+ def setUp(self):
+ """Set up configuration."""
+ try:
+ __import__('bs4')
+ except ImportError:
+ self.skipTest('Beautiful Soup 4 not available')
+ if sys.version_info[:3] < (2, 7, 3):
+ self.skipTest("Python's built-in HTML parser is not good enough")
+
+
+class GeniusScrapeLyricsFromHtmlTest(GeniusBaseTest):
+ """tests Genius._scrape_lyrics_from_html()"""
+
+ def setUp(self):
+ """Set up configuration"""
+ GeniusBaseTest.setUp(self)
+ self.plugin = lyrics.LyricsPlugin()
+
+ def test_no_lyrics_div(self):
+ """Ensure we don't crash when the scraping the html for a genius page
+ doesn't contain
+ """
+ # https://github.com/beetbox/beets/issues/3535
+ # expected return value None
+ url = 'https://genius.com/sample'
+ mock = MockFetchUrl()
+ self.assertEqual(genius._scrape_lyrics_from_html(mock(url)), None)
+
+ def test_good_lyrics(self):
+ """Ensure we are able to scrape a page with lyrics"""
+ url = 'https://genius.com/Wu-tang-clan-cream-lyrics'
+ mock = MockFetchUrl()
+ self.assertIsNotNone(genius._scrape_lyrics_from_html(mock(url)))
+
+ # TODO: find an example of a lyrics page with multiple divs and test it
+
+
+class GeniusFetchTest(GeniusBaseTest):
+ """tests Genius.fetch()"""
+
+ def setUp(self):
+ """Set up configuration"""
+ GeniusBaseTest.setUp(self)
+ self.plugin = lyrics.LyricsPlugin()
+
+ @patch.object(lyrics.Genius, '_scrape_lyrics_from_html')
+ @patch.object(lyrics.Backend, 'fetch_url', return_value=True)
+ def test_json(self, mock_fetch_url, mock_scrape):
+ """Ensure we're finding artist matches"""
+ with patch.object(
+ lyrics.Genius, '_search', return_value={
+ "response": {
+ "hits": [
+ {
+ "result": {
+ "primary_artist": {
+ "name": u"\u200Bblackbear",
+ },
+ "url": "blackbear_url"
+ }
+ },
+ {
+ "result": {
+ "primary_artist": {
+ "name": u"El\u002Dp"
+ },
+ "url": "El-p_url"
+ }
+ }
+ ]
+ }
+ }
+ ) as mock_json:
+ # genius uses zero-width-spaces (\u200B) for lowercase
+ # artists so we make sure we can match those
+ self.assertIsNotNone(genius.fetch('blackbear', 'Idfc'))
+ mock_fetch_url.assert_called_once_with("blackbear_url")
+ mock_scrape.assert_called_once_with(True)
+
+ # genius uses the hypen minus (\u002D) as their dash
+ self.assertIsNotNone(genius.fetch('El-p', 'Idfc'))
+ mock_fetch_url.assert_called_with('El-p_url')
+ mock_scrape.assert_called_with(True)
+
+ # test no matching artist
+ self.assertIsNone(genius.fetch('doesntexist', 'none'))
+
+ # test invalid json
+ mock_json.return_value = None
+ self.assertIsNone(genius.fetch('blackbear', 'Idfc'))
+
+ # TODO: add integration test hitting real api
+
+
+# test utilties
+
class SlugTests(unittest.TestCase):
def test_slug(self):
# plain ascii passthrough
text = u"test"
self.assertEqual(lyrics.slug(text), 'test')
+
# german unicode and capitals
text = u"Mørdag"
self.assertEqual(lyrics.slug(text), 'mordag')
+
# more accents and quotes
text = u"l'été c'est fait pour jouer"
self.assertEqual(lyrics.slug(text), 'l-ete-c-est-fait-pour-jouer')
+
# accents, parens and spaces
text = u"\xe7afe au lait (boisson)"
self.assertEqual(lyrics.slug(text), 'cafe-au-lait-boisson')
text = u"Multiple spaces -- and symbols! -- merged"
self.assertEqual(lyrics.slug(text),
'multiple-spaces-and-symbols-merged')
+ text = u"\u200Bno-width-space"
+ self.assertEqual(lyrics.slug(text), 'no-width-space')
+
+ # variations of dashes should get standardized
+ dashes = [u'\u200D', u'\u2010']
+ for dash1, dash2 in itertools.combinations(dashes, 2):
+ self.assertEqual(lyrics.slug(dash1), lyrics.slug(dash2))
def suite():
diff --git a/test/test_mpdstats.py b/test/test_mpdstats.py
index 0117e22aa..20226927f 100644
--- a/test/test_mpdstats.py
+++ b/test/test_mpdstats.py
@@ -62,10 +62,11 @@ class MPDStatsTest(unittest.TestCase, TestHelper):
{'state': u'stop'}]
EVENTS = [["player"]] * (len(STATUSES) - 1) + [KeyboardInterrupt]
item_path = util.normpath('/foo/bar.flac')
+ songid = 1
@patch("beetsplug.mpdstats.MPDClientWrapper", return_value=Mock(**{
"events.side_effect": EVENTS, "status.side_effect": STATUSES,
- "currentsong.return_value": item_path}))
+ "currentsong.return_value": (item_path, songid)}))
def test_run_mpdstats(self, mpd_mock):
item = Item(title=u'title', path=self.item_path, id=1)
item.add(self.lib)
diff --git a/test/test_parentwork.py b/test/test_parentwork.py
index aa25c7f51..df6a98d79 100644
--- a/test/test_parentwork.py
+++ b/test/test_parentwork.py
@@ -17,6 +17,7 @@
from __future__ import division, absolute_import, print_function
+import os
import unittest
from test.helper import TestHelper
@@ -34,6 +35,9 @@ class ParentWorkTest(unittest.TestCase, TestHelper):
self.unload_plugins()
self.teardown_beets()
+ @unittest.skipUnless(
+ os.environ.get('INTEGRATION_TEST', '0') == '1',
+ 'integration testing not enabled')
def test_normal_case(self):
item = Item(path='/file',
mb_workid=u'e27bda6e-531e-36d3-9cd7-b8ebc18e8c53')
@@ -45,6 +49,9 @@ class ParentWorkTest(unittest.TestCase, TestHelper):
self.assertEqual(item['mb_parentworkid'],
u'32c8943f-1b27-3a23-8660-4567f4847c94')
+ @unittest.skipUnless(
+ os.environ.get('INTEGRATION_TEST', '0') == '1',
+ 'integration testing not enabled')
def test_force(self):
self.config['parentwork']['force'] = True
item = Item(path='/file',
@@ -58,6 +65,9 @@ class ParentWorkTest(unittest.TestCase, TestHelper):
self.assertEqual(item['mb_parentworkid'],
u'32c8943f-1b27-3a23-8660-4567f4847c94')
+ @unittest.skipUnless(
+ os.environ.get('INTEGRATION_TEST', '0') == '1',
+ 'integration testing not enabled')
def test_no_force(self):
self.config['parentwork']['force'] = True
item = Item(path='/file', mb_workid=u'e27bda6e-531e-36d3-9cd7-\
@@ -72,6 +82,9 @@ class ParentWorkTest(unittest.TestCase, TestHelper):
# test different cases, still with Matthew Passion Ouverture or Mozart
# requiem
+ @unittest.skipUnless(
+ os.environ.get('INTEGRATION_TEST', '0') == '1',
+ 'integration testing not enabled')
def test_direct_parent_work(self):
mb_workid = u'2e4a3668-458d-3b2a-8be2-0b08e0d8243a'
self.assertEqual(u'f04b42df-7251-4d86-a5ee-67cfa49580d1',
diff --git a/test/test_player.py b/test/test_player.py
index 021a04fc0..dd47ac62b 100644
--- a/test/test_player.py
+++ b/test/test_player.py
@@ -241,6 +241,8 @@ def implements(commands, expectedFailure=False): # noqa: N803
bluelet_listener = bluelet.Listener
+
+
@mock.patch("beets.util.bluelet.Listener")
def start_server(args, assigned_port, listener_patch):
"""Start the bpd server, writing the port to `assigned_port`.
diff --git a/test/test_playlist.py b/test/test_playlist.py
index edd98e711..88abb733f 100644
--- a/test/test_playlist.py
+++ b/test/test_playlist.py
@@ -120,7 +120,7 @@ class PlaylistQueryTestHelper(PlaylistTestHelper):
]))
def test_name_query_with_nonexisting_playlist(self):
- q = u'playlist:nonexisting'.format(self.playlist_dir)
+ q = u'playlist:nonexisting'
results = self.lib.items(q)
self.assertEqual(set(results), set())
diff --git a/test/test_plexupdate.py b/test/test_plexupdate.py
index f8b0bdcd9..ef89892a4 100644
--- a/test/test_plexupdate.py
+++ b/test/test_plexupdate.py
@@ -93,7 +93,9 @@ class PlexUpdateTest(unittest.TestCase, TestHelper):
self.config['plex']['host'],
self.config['plex']['port'],
self.config['plex']['token'],
- self.config['plex']['library_name'].get()), '2')
+ self.config['plex']['library_name'].get(),
+ self.config['plex']['secure'],
+ self.config['plex']['ignore_cert_errors']), '2')
@responses.activate
def test_get_named_music_section(self):
@@ -104,7 +106,9 @@ class PlexUpdateTest(unittest.TestCase, TestHelper):
self.config['plex']['host'],
self.config['plex']['port'],
self.config['plex']['token'],
- 'My Music Library'), '2')
+ 'My Music Library',
+ self.config['plex']['secure'],
+ self.config['plex']['ignore_cert_errors']), '2')
@responses.activate
def test_update_plex(self):
@@ -117,7 +121,9 @@ class PlexUpdateTest(unittest.TestCase, TestHelper):
self.config['plex']['host'],
self.config['plex']['port'],
self.config['plex']['token'],
- self.config['plex']['library_name'].get()).status_code, 200)
+ self.config['plex']['library_name'].get(),
+ self.config['plex']['secure'],
+ self.config['plex']['ignore_cert_errors']).status_code, 200)
def suite():
diff --git a/test/test_query.py b/test/test_query.py
index c0ab2a171..f88a12c92 100644
--- a/test/test_query.py
+++ b/test/test_query.py
@@ -772,6 +772,21 @@ class NoneQueryTest(unittest.TestCase, TestHelper):
matched = self.lib.items(NoneQuery(u'rg_track_gain'))
self.assertInResult(item, matched)
+ def test_match_slow(self):
+ item = self.add_item()
+ matched = self.lib.items(NoneQuery(u'rg_track_peak', fast=False))
+ self.assertInResult(item, matched)
+
+ def test_match_slow_after_set_none(self):
+ item = self.add_item(rg_track_gain=0)
+ matched = self.lib.items(NoneQuery(u'rg_track_gain', fast=False))
+ self.assertNotInResult(item, matched)
+
+ item['rg_track_gain'] = None
+ item.store()
+ matched = self.lib.items(NoneQuery(u'rg_track_gain', fast=False))
+ self.assertInResult(item, matched)
+
class NotQueryMatchTest(_common.TestCase):
"""Test `query.NotQuery` matching against a single item, using the same
diff --git a/test/test_replaygain.py b/test/test_replaygain.py
index 437b1426a..969f5c230 100644
--- a/test/test_replaygain.py
+++ b/test/test_replaygain.py
@@ -58,6 +58,7 @@ def reset_replaygain(item):
class ReplayGainCliTestBase(TestHelper):
+
def setUp(self):
self.setup_beets()
self.config['replaygain']['backend'] = self.backend
@@ -150,7 +151,9 @@ class ReplayGainCliTestBase(TestHelper):
self.assertEqual(max(gains), min(gains))
self.assertNotEqual(max(gains), 0.0)
- self.assertNotEqual(max(peaks), 0.0)
+ if not self.backend == "bs1770gain":
+ # Actually produces peaks == 0.0 ~ self.add_album_fixture
+ self.assertNotEqual(max(peaks), 0.0)
def test_cli_writes_only_r128_tags(self):
if self.backend == "command":
@@ -227,7 +230,9 @@ class ReplayGainLdnsCliMalformedTest(TestHelper, unittest.TestCase):
# Patch call to return nothing, bypassing the bs1770gain installation
# check.
- call_patch.return_value = CommandOutput(stdout=b"", stderr=b"")
+ call_patch.return_value = CommandOutput(
+ stdout=b'bs1770gain 0.0.0, ', stderr=b''
+ )
try:
self.load_plugins('replaygain')
except Exception:
@@ -249,7 +254,7 @@ class ReplayGainLdnsCliMalformedTest(TestHelper, unittest.TestCase):
@patch('beetsplug.replaygain.call')
def test_malformed_output(self, call_patch):
# Return malformed XML (the ampersand should be &)
- call_patch.return_value = CommandOutput(stdout="""
+ call_patch.return_value = CommandOutput(stdout=b"""