From 703f47ae976ed4e95de4cb974d7785ab53b8cea5 Mon Sep 17 00:00:00 2001 From: Adrian Sampson Date: Tue, 10 Jan 2017 21:01:36 -0500 Subject: [PATCH] Use flexible attribute for track_alt No need for a built-in field for a simple string-type optional field like this. --- beets/library.py | 1 - docs/reference/pathformat.rst | 1 - test/test_edit.py | 2 +- test/test_mb.py | 1 + 4 files changed, 2 insertions(+), 3 deletions(-) diff --git a/beets/library.py b/beets/library.py index 99a84cee6..32176b68d 100644 --- a/beets/library.py +++ b/beets/library.py @@ -423,7 +423,6 @@ class Item(LibModel): 'month': types.PaddedInt(2), 'day': types.PaddedInt(2), 'track': types.PaddedInt(2), - 'track_alt': types.STRING, 'tracktotal': types.PaddedInt(2), 'disc': types.PaddedInt(2), 'disctotal': types.PaddedInt(2), diff --git a/docs/reference/pathformat.rst b/docs/reference/pathformat.rst index 6b1fe5021..72453a6e5 100644 --- a/docs/reference/pathformat.rst +++ b/docs/reference/pathformat.rst @@ -197,7 +197,6 @@ Ordinary metadata: * original_year, original_month, original_day: The release date of the original version of the album. * track -* track_alt * tracktotal * disc * disctotal diff --git a/test/test_edit.py b/test/test_edit.py index 0449f2333..2900d092a 100644 --- a/test/test_edit.py +++ b/test/test_edit.py @@ -276,7 +276,7 @@ class EditDuringImporterTest(TerminalImportSessionSetup, unittest.TestCase, ImportHelper, TestHelper, EditMixin): """TODO """ - IGNORED = ['added', 'album_id', 'id', 'mtime', 'path', 'track_alt'] + IGNORED = ['added', 'album_id', 'id', 'mtime', 'path'] def setUp(self): self.setup_beets() diff --git a/test/test_mb.py b/test/test_mb.py index 9e4226307..ca1bf2a1a 100644 --- a/test/test_mb.py +++ b/test/test_mb.py @@ -189,6 +189,7 @@ class MBAlbumInfoTest(_common.TestCase): 'position': '2', 'track-list': second_track_list, }) + d = mb.album_info(release) self.assertEqual(d.mediums, 2) t = d.tracks