Backup_Repos/beets
1
0
Fork 0
mirror of https://github.com/beetbox/beets.git synced 2025-12-15 21:14:19 +01:00
Code Issues Projects Releases Wiki Activity

opus: remove image from test file

Browse source 
The encoder that produced this file for some reason included an empty image as
the cover art and was confusing the tests.

I left the null check in place to deal with this situation in the future. I
think returning None is better than returning the empty string (which is of
course not a valid image).
This commit is contained in:
Adrian Sampson 2013-09-12 10:16:47 -07:00
parent 8dc1e223e9
commit 6857267cc7
3 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
beets/mediafile.py
View file

@ -756,9 +756,9 @@ class ImageField(object):
return None
else:
# Here we're assuming everything but MP3, MPEG-4, and FLAC
# use the Xiph/Vorbis Comments standard. This may not be
# valid. http://wiki.xiph.org/VorbisComment#Cover_art
# Here we're assuming everything but MP3, MPEG-4, FLAC, and
# ASF/WMA use the Xiph/Vorbis Comments standard. This may
# not be valid. http://wiki.xiph.org/VorbisComment#Cover_art
if 'metadata_block_picture' not in obj.mgfile:
# Try legacy COVERART tags.
@ -775,7 +775,7 @@ class ImageField(object):
else:
return None
if pic.data == '':
if not pic.data:
return None
return pic.data

BIN
test/rsrc/full.opus
View file

Binary file not shown.

2
test/test_mediafile_basic.py
View file

@ -175,7 +175,7 @@ READ_ONLY_CORRECT_DICTS = {
'full.opus': {
'length': 1.0,
'bitrate': 63216,
'bitrate': 57984,
'format': 'Opus',
'samplerate': 48000,
'bitdepth': 0,