Backup_Repos/beets
1
0
Fork 0
mirror of https://github.com/beetbox/beets.git synced 2026-04-01 19:23:55 +02:00
Code Issues Projects Releases Wiki Activity

Remove outdated GeniusLyrics test

Browse source 
The test for GeniusLyrics was heavily patched and no longer provided
useful coverage. It has been removed to clean up the test suite.
This commit is contained in:
Šarūnas Nejus 2024-10-02 20:42:04 +01:00
parent 35dcfe508a
commit 67e0af526c
No known key found for this signature in database
GPG key ID: DD28F6704DBE3435
1 changed files with 0 additions and 47 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

47
test/plugins/test_lyrics.py
View file

@ -18,7 +18,6 @@ import itertools
import os
import unittest
from functools import partial
from unittest.mock import patch
import pytest
@ -342,52 +341,6 @@ class TestGeniusLyrics(LyricsBackendTest):
assert len(result.splitlines()) == expected_line_count
@patch.object(lyrics.Genius, "_scrape_lyrics_from_html")
@patch.object(lyrics.Backend, "fetch_url", return_value=True)
def test_json(self, mock_fetch_url, mock_scrape, backend):
"""Ensure we're finding artist matches"""
with patch.object(
lyrics.Genius,
"_search",
return_value={
"response": {
"hits": [
{
"result": {
"primary_artist": {
"name": "\u200bblackbear",
},
"url": "blackbear_url",
}
},
{
"result": {
"primary_artist": {"name": "El\u002dp"},
"url": "El-p_url",
}
},
]
}
},
) as mock_json:
# genius uses zero-width-spaces (\u200B) for lowercase
# artists so we make sure we can match those
assert backend.fetch("blackbear", "Idfc") is not None
mock_fetch_url.assert_called_once_with("blackbear_url")
mock_scrape.assert_called_once_with(True)
# genius uses the hyphen minus (\u002D) as their dash
assert backend.fetch("El-p", "Idfc") is not None
mock_fetch_url.assert_called_with("El-p_url")
mock_scrape.assert_called_with(True)
# test no matching artist
assert backend.fetch("doesntexist", "none") is None
# test invalid json
mock_json.return_value = None
assert backend.fetch("blackbear", "Idfc") is None
class TestTekstowoLyrics(LyricsBackendTest):
@pytest.fixture(scope="class")