From 669307c91cec8b15610bbbcafea29de3d96c23e7 Mon Sep 17 00:00:00 2001 From: Karl Besser Date: Mon, 30 Sep 2024 10:28:23 -0500 Subject: [PATCH] Update ftintitle.contains_feat unit tests Since the `for_artist` keyword has been removed from `ftintitle.contains_feat`, the unit tests need to be updated. This includes the deletion of the test cases that test the `for_artist=True` delimiters. --- test/plugins/test_ftintitle.py | 23 ++++++----------------- 1 file changed, 6 insertions(+), 17 deletions(-) diff --git a/test/plugins/test_ftintitle.py b/test/plugins/test_ftintitle.py index 6347d814b..5568c94b1 100644 --- a/test/plugins/test_ftintitle.py +++ b/test/plugins/test_ftintitle.py @@ -175,14 +175,11 @@ class FtInTitlePluginTest(unittest.TestCase): parts = ftintitle.split_on_feat("Alice defeat Bob") assert parts == ("Alice defeat Bob", None) - def test_contains_feat_artist(self): + def test_contains_feat(self): assert ftintitle.contains_feat("Alice ft. Bob") assert ftintitle.contains_feat("Alice feat. Bob") assert ftintitle.contains_feat("Alice feat Bob") assert ftintitle.contains_feat("Alice featuring Bob") - assert ftintitle.contains_feat("Alice & Bob") - assert ftintitle.contains_feat("Alice and Bob") - assert ftintitle.contains_feat("Alice With Bob") assert ftintitle.contains_feat("Alice (ft. Bob)") assert ftintitle.contains_feat("Alice (feat. Bob)") assert ftintitle.contains_feat("Alice [ft. Bob]") @@ -190,16 +187,8 @@ class FtInTitlePluginTest(unittest.TestCase): assert not ftintitle.contains_feat("Alice defeat Bob") assert not ftintitle.contains_feat("Aliceft.Bob") assert not ftintitle.contains_feat("Alice (defeat Bob)") - - def test_contains_feat_title(self): - assert ftintitle.contains_feat( - "Live and Let Go (feat. Alice)", for_artist=False - ) - assert ftintitle.contains_feat( - "Live and Let Go [feat. Alice]", for_artist=False - ) - assert ftintitle.contains_feat( - "Live and Let Go feat. Alice", for_artist=False - ) - assert not ftintitle.contains_feat("Live and Let Go", for_artist=False) - assert not ftintitle.contains_feat("Come With Me", for_artist=False) + assert ftintitle.contains_feat("Live and Let Go (feat. Alice)") + assert ftintitle.contains_feat("Live and Let Go [feat. Alice]") + assert ftintitle.contains_feat("Live and Let Go feat. Alice") + assert not ftintitle.contains_feat("Live and Let Go") + assert not ftintitle.contains_feat("Come With Me")