Merge pull request #234 from duailibe/error_messages

Human-friendly error messages

beets/ui/commands.py

@@ -798,7 +798,12 @@ def update_items(lib, query, album, move, pretend):
 
             # Read new data.
             old_data = dict(item.record)
-            item.read()
+            try:
+                item.read()
+            except Exception as exc:
+                log.error(u'error reading {0}: {1}'.format(
+                    displayable_path(item.path), exc))
+                continue
 
             # Special-case album artist when it matches track artist. (Hacky
             # but necessary for preserving album-level metadata for non-

beetsplug/embedart.py

@@ -20,7 +20,7 @@ from beets.plugins import BeetsPlugin
 from beets import mediafile
 from beets import ui
 from beets.ui import decargs
-from beets.util import syspath, normpath
+from beets.util import syspath, normpath, displayable_path
 from beets.util.artresizer import ArtResizer
 from beets import config
 
@@ -46,7 +46,7 @@ def _embed(path, items, maxwidth=0):
             f = mediafile.MediaFile(syspath(item.path))
         except mediafile.UnreadableFileError as exc:
             log.warn('Could not embed art in {0}: {1}'.format(
-                repr(item.path), exc
+                displayable_path(item.path), exc
             ))
             continue
         f.art = data
@@ -140,7 +140,14 @@ def extract(lib, outpath, query):
         return
 
     # Extract the art.
-    mf = mediafile.MediaFile(syspath(item.path))
+    try:
+        mf = mediafile.MediaFile(syspath(item.path))
+    except mediafile.UnreadableFileError as exc:
+        log.error(u'Could not extract art from {0}: {1}'.format(
+            displayable_path(item.path), exc
+        ))
+        return
+
     art = mf.art
     if not art:
         log.error('No album art present in %s - %s.' %
@@ -165,7 +172,13 @@ def clear(lib, query):
     log.info('Clearing album art from items:')
     for item in lib.items(query):
         log.info(u'%s - %s' % (item.artist, item.title))
-        mf = mediafile.MediaFile(syspath(item.path))
+        try:
+            mf = mediafile.MediaFile(syspath(item.path))
+        except mediafile.UnreadableFileError as exc:
+            log.error(u'Could not clear art from {0}: {1}'.format(
+                displayable_path(item.path), exc
+            ))
+            continue
         mf.art = None
         mf.save()
 

beetsplug/mbsync.py

@@ -47,7 +47,12 @@ def _print_and_apply_changes(lib, item, move, pretend, write):
             lib.move(item, with_album=False)
 
         if write:
-            item.write()
+            try:
+                item.write()
+            except Exception as exc:
+                log.error(u'could not sync {0}: {1}'.format(
+                    util.displayable_path(item.path), exc))
+                return False
         lib.store(item)
 
     return True