From 63af350eaa173c5958e8157de5b6e09e002ff95c Mon Sep 17 00:00:00 2001 From: Adrian Sampson Date: Thu, 5 Jun 2014 16:53:23 -0700 Subject: [PATCH] Diff output shows formatted values for strings This is why, in #807, the album field was appearing to "work" while the year field was displaying the issue. We were colorizing the wrong value. Now, of course, we need to fix the underlying issue: we're confusingly displaying album-level information for these items. --- beets/ui/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/beets/ui/__init__.py b/beets/ui/__init__.py index 00b217850..3d1d358a6 100644 --- a/beets/ui/__init__.py +++ b/beets/ui/__init__.py @@ -582,7 +582,7 @@ def _field_diff(field, old, new): # For strings, highlight changes. For others, colorize the whole # thing. if isinstance(oldval, basestring): - oldstr, newstr = colordiff(oldval, newval) + oldstr, newstr = colordiff(oldval, newstr) else: oldstr, newstr = colorize('red', oldstr), colorize('red', newstr)