From 61ffc165df64eab8c8cf3c5add13e0bca6e3c5cd Mon Sep 17 00:00:00 2001 From: Adrian Sampson Date: Sun, 5 Apr 2015 12:28:14 -0700 Subject: [PATCH] Tests: avoid leaking a mock The decorator is now necessary because we're patching a module-global. --- test/test_embedart.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/test/test_embedart.py b/test/test_embedart.py index 16899975e..31187d0cc 100644 --- a/test/test_embedart.py +++ b/test/test_embedart.py @@ -17,7 +17,7 @@ from __future__ import (division, absolute_import, print_function, import os.path import shutil -from mock import Mock, patch +from mock import patch from test import _common from test._common import unittest @@ -128,10 +128,11 @@ class EmbedartCliTest(_common.TestCase, TestHelper): 'extracted.png')) -class EmbedartTest(unittest.TestCase): - @patch('beets.art.subprocess') - def test_imagemagick_response(self, mock_subprocess): - art.extract = Mock(return_value=True) +@patch('beets.art.subprocess') +@patch('beets.art.extract') +class ArtSimilarityTest(unittest.TestCase): + def test_imagemagick_response(self, mock_extract, mock_subprocess): + mock_extract.return_value = True proc = mock_subprocess.Popen.return_value log = logging.getLogger('beets.embedart')