From 6180ce1973e42f81f1652f351e896790bf43190b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=A0ar=C5=ABnas=20Nejus?= Date: Wed, 30 Oct 2024 12:27:44 +0000 Subject: [PATCH] Revert "ci: Replace pull_request with pull_request_target" This was a very bad idea since this made CI operate within the context of the *base* branch, which meant that the tests were testing code in the `master` branch instead of the branch that was to be merged! --- .github/workflows/ci.yaml | 2 +- .github/workflows/lint.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 44ba7cc10..18c77b2d2 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -1,6 +1,6 @@ name: Test on: - pull_request_target: + pull_request: push: branches: - master diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index d9b313743..c803e66cd 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -1,7 +1,7 @@ name: Lint check run-name: Lint code on: - pull_request_target: + pull_request: push: branches: - master