From 611659d03c6e75b25aea994cf9daa0732df61679 Mon Sep 17 00:00:00 2001 From: Adam Jakab Date: Mon, 16 Mar 2020 10:16:18 +0100 Subject: [PATCH] removed value_match and repr tests --- beets/dbcore/query.py | 7 +------ test/test_query.py | 17 ----------------- 2 files changed, 1 insertion(+), 23 deletions(-) diff --git a/beets/dbcore/query.py b/beets/dbcore/query.py index e4f5b8a29..db4b861c4 100644 --- a/beets/dbcore/query.py +++ b/beets/dbcore/query.py @@ -152,17 +152,12 @@ class NoneQuery(FieldQuery): def __init__(self, field, fast=True): super(NoneQuery, self).__init__(field, None, fast) - self.pattern = None def col_clause(self): return self.field + " IS NULL", () def match(self, item): - return self.value_match(self.pattern, - item.get(self.field, default=None)) - - def value_match(self, pattern, value): - return value is pattern + return item.get(self.field, default=None) is None def __repr__(self): return "{0.__class__.__name__}({0.field!r}, {0.fast})".format(self) diff --git a/test/test_query.py b/test/test_query.py index fc8e76735..f88a12c92 100644 --- a/test/test_query.py +++ b/test/test_query.py @@ -787,23 +787,6 @@ class NoneQueryTest(unittest.TestCase, TestHelper): matched = self.lib.items(NoneQuery(u'rg_track_gain', fast=False)) self.assertInResult(item, matched) - def test_query_repr(self): - fld = u'rg_track_gain' - if sys.version_info <= (3, 0): - self.assertEquals("NoneQuery(u'{}', True)".format(fld), - str(NoneQuery(fld))) - self.assertEquals("NoneQuery(u'{}', True)".format(fld), - str(NoneQuery(fld, fast=True))) - self.assertEquals("NoneQuery(u'{}', False)".format(fld), - str(NoneQuery(fld, fast=False))) - else: - self.assertEquals("NoneQuery('{}', True)".format(fld), - str(NoneQuery(fld))) - self.assertEquals("NoneQuery('{}', True)".format(fld), - str(NoneQuery(fld, fast=True))) - self.assertEquals("NoneQuery('{}', False)".format(fld), - str(NoneQuery(fld, fast=False))) - class NotQueryMatchTest(_common.TestCase): """Test `query.NotQuery` matching against a single item, using the same