From 60b1819db0de6d601a150e7ffd135d7e73667be4 Mon Sep 17 00:00:00 2001 From: Arturo R Date: Mon, 9 Feb 2015 09:55:32 -0800 Subject: [PATCH] Stop applying mp3gain directly to files. Fixes #1316 Update docs to remove non-existent `apply` option. --- beetsplug/replaygain.py | 1 - docs/changelog.rst | 2 ++ docs/plugins/replaygain.rst | 5 ----- 3 files changed, 2 insertions(+), 6 deletions(-) diff --git a/beetsplug/replaygain.py b/beetsplug/replaygain.py index 4ec407cfb..ce41cad57 100644 --- a/beetsplug/replaygain.py +++ b/beetsplug/replaygain.py @@ -179,7 +179,6 @@ class CommandBackend(Backend): else: # Disable clipping warning. cmd = cmd + ['-c'] - cmd = cmd + ['-a' if is_album else '-r'] cmd = cmd + ['-d', bytes(self.gain_offset)] cmd = cmd + [syspath(i.path) for i in items] diff --git a/docs/changelog.rst b/docs/changelog.rst index 81493428c..00a225b01 100644 --- a/docs/changelog.rst +++ b/docs/changelog.rst @@ -63,6 +63,8 @@ Core changes: Fixes: +* :doc:`/plugins/replaygain`: Stop applying replaygain directly to source files + when using the mp3gain backend. :bug:`1316` * :doc:`/plugins/lyrics`: Silence a warning about insecure requests in the new MusixMatch backend. :bug:`1204` * Fix a crash when ``beet`` is invoked without arguments. :bug:`1205` diff --git a/docs/plugins/replaygain.rst b/docs/plugins/replaygain.rst index d572902dd..d2584a648 100644 --- a/docs/plugins/replaygain.rst +++ b/docs/plugins/replaygain.rst @@ -92,11 +92,6 @@ configuration file. The available options are: These options only work with the "command" backend: -- **apply**: If you use a player that does not support ReplayGain - specifications, you can force the volume normalization by applying the gain - to the file via the ``apply`` option. This is a lossless and reversible - operation with no transcoding involved. - Default: ``no``. - **command**: The path to the ``mp3gain`` or ``aacgain`` executable (if beets cannot find it by itself). For example: ``/Applications/MacMP3Gain.app/Contents/Resources/aacgain``.