From 59b636ac8c2e08994d9fe16640bf710bac8e3e3e Mon Sep 17 00:00:00 2001 From: Jack Date: Mon, 9 Mar 2026 18:05:37 -0400 Subject: [PATCH] CI: install discogs extra so discogs tests run; remove skip logic --- .github/workflows/ci.yaml | 4 ++-- test/plugins/test_discogs.py | 8 -------- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 0736a0a2f..40e557a18 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -72,7 +72,7 @@ jobs: - if: ${{ env.IS_MAIN_PYTHON != 'true' }} name: Test without coverage run: | - poetry install --without=lint --extras=autobpm --extras=lyrics --extras=replaygain --extras=reflink --extras=fetchart --extras=chroma --extras=sonosupdate + poetry install --without=lint --extras=autobpm --extras=discogs --extras=lyrics --extras=replaygain --extras=reflink --extras=fetchart --extras=chroma --extras=sonosupdate poe test - if: ${{ env.IS_MAIN_PYTHON == 'true' }} @@ -80,7 +80,7 @@ jobs: env: LYRICS_UPDATED: ${{ steps.lyrics-update.outputs.any_changed }} run: | - poetry install --extras=autobpm --extras=lyrics --extras=docs --extras=replaygain --extras=reflink --extras=fetchart --extras=chroma --extras=sonosupdate + poetry install --extras=autobpm --extras=discogs --extras=lyrics --extras=docs --extras=replaygain --extras=reflink --extras=fetchart --extras=chroma --extras=sonosupdate poe docs poe test-with-coverage diff --git a/test/plugins/test_discogs.py b/test/plugins/test_discogs.py index 2b3586f16..d0c6b7021 100644 --- a/test/plugins/test_discogs.py +++ b/test/plugins/test_discogs.py @@ -18,14 +18,6 @@ from unittest.mock import Mock, patch import pytest -try: - import discogs_client # noqa: F401 -except ImportError: - pytest.skip( - "discogs optional dependency not installed", - allow_module_level=True, - ) - from beets import config from beets.library import Item from beets.test._common import Bag