From 5900282093c484d964377fa5d40151bd18a2bd56 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=A0ar=C5=ABnas=20Nejus?= Date: Mon, 26 May 2025 13:05:40 +0100 Subject: [PATCH] Use BeetsTestCase for lastgenre tests, re-use the defined config --- test/plugins/test_lastgenre.py | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/test/plugins/test_lastgenre.py b/test/plugins/test_lastgenre.py index d34860774..be145d811 100644 --- a/test/plugins/test_lastgenre.py +++ b/test/plugins/test_lastgenre.py @@ -14,17 +14,16 @@ """Tests for the 'lastgenre' plugin.""" -import unittest from unittest.mock import Mock import pytest -from beets import config from beets.test import _common +from beets.test.helper import BeetsTestCase from beetsplug import lastgenre -class LastGenrePluginTest(unittest.TestCase): +class LastGenrePluginTest(BeetsTestCase): def setUp(self): super().setUp() self.plugin = lastgenre.LastGenrePlugin() @@ -32,12 +31,12 @@ class LastGenrePluginTest(unittest.TestCase): def _setup_config( self, whitelist=False, canonical=False, count=1, prefer_specific=False ): - config["lastgenre"]["canonical"] = canonical - config["lastgenre"]["count"] = count - config["lastgenre"]["prefer_specific"] = prefer_specific + self.config["lastgenre"]["canonical"] = canonical + self.config["lastgenre"]["count"] = count + self.config["lastgenre"]["prefer_specific"] = prefer_specific if isinstance(whitelist, (bool, (str,))): # Filename, default, or disabled. - config["lastgenre"]["whitelist"] = whitelist + self.config["lastgenre"]["whitelist"] = whitelist self.plugin.setup() if not isinstance(whitelist, (bool, (str,))): # Explicit list of genres. @@ -463,11 +462,10 @@ def test_get_genre(config_values, item_genre, mock_genres, expected_result): lastgenre.LastGenrePlugin.fetch_album_genre = mock_fetch_album_genre lastgenre.LastGenrePlugin.fetch_artist_genre = mock_fetch_artist_genre - # Configure - config["lastgenre"] = config_values - # Initialize plugin instance and item plugin = lastgenre.LastGenrePlugin() + # Configure + plugin.config.set(config_values) item = _common.item() item.genre = item_genre