From 55bd513278caedc3b0e1bd2662dc6fdf41c95df0 Mon Sep 17 00:00:00 2001 From: Jack Wilsdon Date: Sat, 12 Sep 2015 02:16:22 +0100 Subject: [PATCH] Remove completed TODO comments --- beetsplug/hook.py | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/beetsplug/hook.py b/beetsplug/hook.py index af411f20f..7925b16c8 100644 --- a/beetsplug/hook.py +++ b/beetsplug/hook.py @@ -23,21 +23,6 @@ from beets.plugins import BeetsPlugin def create_hook_function(log, event, command, shell, substitute_args): - - # TODO: Find a better way of piping STDOUT/STDERR/STDIN between the process - # and the user. - # - # The issue with our current method is that we can only pesudo-pipe - # one (two if we count STDERR being piped to STDOUT) stream at a - # time, meaning we can't have both output and input simultaneously. - # This is due to how Popen.std(out/err) works, as - # Popen.std(out/err).readline() waits until a newline has been output - # to the stream before returning. - - # TODO: Find a better way of converting arguments to strings, as I - # currently have a feeling that forcing everything to utf-8 might - # end up causing a mess. - def hook_function(**kwargs): hook_command = command