From 9f13eaeb15d12c32f92563d8183afb0997d23175 Mon Sep 17 00:00:00 2001 From: ybnd Date: Fri, 10 Dec 2021 18:33:24 +0100 Subject: [PATCH 1/2] Make r128 fields floats --- beets/library.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/beets/library.py b/beets/library.py index 888836cd9..56aff6351 100644 --- a/beets/library.py +++ b/beets/library.py @@ -515,8 +515,8 @@ class Item(LibModel): 'rg_track_peak': types.NULL_FLOAT, 'rg_album_gain': types.NULL_FLOAT, 'rg_album_peak': types.NULL_FLOAT, - 'r128_track_gain': types.NullPaddedInt(6), - 'r128_album_gain': types.NullPaddedInt(6), + 'r128_track_gain': types.NULL_FLOAT, + 'r128_album_gain': types.NULL_FLOAT, 'original_year': types.PaddedInt(4), 'original_month': types.PaddedInt(2), 'original_day': types.PaddedInt(2), @@ -1058,7 +1058,7 @@ class Album(LibModel): 'releasegroupdisambig': types.STRING, 'rg_album_gain': types.NULL_FLOAT, 'rg_album_peak': types.NULL_FLOAT, - 'r128_album_gain': types.NullPaddedInt(6), + 'r128_album_gain': types.NULL_FLOAT, 'original_year': types.PaddedInt(4), 'original_month': types.PaddedInt(2), 'original_day': types.PaddedInt(2), From 38fc1d453248545d8fd44edebdf90dd57d1bc907 Mon Sep 17 00:00:00 2001 From: ybnd Date: Sun, 12 Dec 2021 12:10:50 +0100 Subject: [PATCH 2/2] Add changelog entry for r128 type change --- docs/changelog.rst | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/docs/changelog.rst b/docs/changelog.rst index 8d95b7fb0..3dd225864 100644 --- a/docs/changelog.rst +++ b/docs/changelog.rst @@ -11,6 +11,10 @@ Bug fixes: * :doc:`/plugins/lyrics`: Fix Genius search by using query params instead of body. * :doc:`/plugins/unimported`: The new ``ignore_subdirectories`` configuration option added in 1.6.0 now has a default value if it hasn't been set. +* :doc:`/plugins/replaygain`: The type of the internal ``r128_track_gain`` and + ``r128_album_gain`` fields was changed from integer to float to fix loss of + precision due to truncation. + :bug:`4169` For packagers: