Backup_Repos/beets
1
0
Fork 0
mirror of https://github.com/beetbox/beets.git synced 2026-01-24 00:51:24 +01:00
Code Issues Projects Releases Wiki Activity

embedart: Error on non-existent -f file

Browse source 
Fixes #1252.
This commit is contained in:
Adrian Sampson 2015-01-21 09:07:59 -08:00
parent e0a48c6cf9
commit 433d6b7485
2 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
beetsplug/embedart.py
View file

@ -68,6 +68,10 @@ class EmbedCoverArtPlugin(BeetsPlugin):
def embed_func(lib, opts, args): def embed_func(lib, opts, args):
if opts.file: if opts.file:
imagepath = normpath(opts.file) imagepath = normpath(opts.file)
if not os.path.isfile(syspath(imagepath)):
raise ui.UserError(u'image file {0} not found'.format(
displayable_path(imagepath)
))
for item in lib.items(decargs(args)): for item in lib.items(decargs(args)):
self.embed_item(item, imagepath, maxwidth, None, self.embed_item(item, imagepath, maxwidth, None,
compare_threshold, ifempty) compare_threshold, ifempty)

2
docs/changelog.rst
View file

@ -44,6 +44,8 @@ Fixes:
* :doc:`/plugins/embedart`: Handle errors in ImageMagick's output. :bug:`1241` * :doc:`/plugins/embedart`: Handle errors in ImageMagick's output. :bug:`1241`
* :doc:`/plugins/keyfinder`: Parse the underlying tool's output more robustly. * :doc:`/plugins/keyfinder`: Parse the underlying tool's output more robustly.
:bug:`1248` :bug:`1248`
* :doc:`/plugins/embedart`: We now show a comprehensible error message when
``beet embedart -f FILE`` is given a non-existent path. :bug:`1252`
For developers: For developers: