Backup_Repos/beets
1
0
Fork 0
mirror of https://github.com/beetbox/beets.git synced 2025-12-06 16:42:42 +01:00
Code Issues Projects Releases Wiki Activity

Warn users of deprecated musicbrainz.enabled option

Browse source
This commit is contained in:
Šarūnas Nejus 2025-10-25 13:14:45 +01:00
parent 9f7cb8dbe4
commit 3bb068a675
No known key found for this signature in database
2 changed files with 11 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
beets/plugins.py
View file

@ -415,16 +415,19 @@ def get_plugin_names() -> list[str]:
sys.path += paths sys.path += paths
plugins = unique_list(beets.config["plugins"].as_str_seq()) plugins = unique_list(beets.config["plugins"].as_str_seq())
# TODO: Remove in v3.0.0 # TODO: Remove in v3.0.0
if ( if "musicbrainz" not in plugins:
"musicbrainz" not in plugins
and beets.config["musicbrainz"].flatten().get("enabled") is not False
):
deprecate_for_user( deprecate_for_user(
log, log,
"Automatic loading of 'musicbrainz' plugin", "Automatic loading of 'musicbrainz' plugin",
"'plugins' configuration to explicitly add 'musicbrainz'", "'plugins' configuration to explicitly add 'musicbrainz'",
) )
plugins.append("musicbrainz") enabled = beets.config["musicbrainz"].flatten().get("enabled")
if enabled is not None:
deprecate_for_user(
log, "'musicbrainz.enabled' configuration option"
)
if enabled is not False:
plugins.append("musicbrainz")
beets.config.add({"disabled_plugins": []}) beets.config.add({"disabled_plugins": []})
disabled_plugins = set(beets.config["disabled_plugins"].as_str_seq()) disabled_plugins = set(beets.config["disabled_plugins"].as_str_seq())

4
beets/util/deprecation.py
View file

@ -21,7 +21,9 @@ def _format_message(old: str, new: str | None = None) -> str:
return msg return msg
def deprecate_for_user(logger: Logger, old: str, new: str) -> None: def deprecate_for_user(
logger: Logger, old: str, new: str | None = None
) -> None:
logger.warning(_format_message(old, new)) logger.warning(_format_message(old, new))