From ac5634d592cbf26ab6d72b9b5e4db17647aa3121 Mon Sep 17 00:00:00 2001 From: Aidan Epstein Date: Sat, 30 Jul 2022 16:10:58 +0000 Subject: [PATCH 1/3] Fix old alias It looks like the convert option for wma used to be called windows media. We could just remove this alias, but might be good to keep for backwards compatibility. --- beetsplug/convert.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/beetsplug/convert.py b/beetsplug/convert.py index a8674ca79..95240dc39 100644 --- a/beetsplug/convert.py +++ b/beetsplug/convert.py @@ -37,7 +37,7 @@ _temp_files = [] # Keep track of temporary transcoded files for deletion. # Some convenient alternate names for formats. ALIASES = { - 'wma': 'windows media', + 'windows media': 'wma', 'vorbis': 'ogg', } From d66a513d80c09db4cceac2bd91197468aea4e281 Mon Sep 17 00:00:00 2001 From: Aidan Epstein Date: Sat, 30 Jul 2022 16:13:18 +0000 Subject: [PATCH 2/3] Fix documentation to refer to wma instead of wmv This format actually has a definition. --- docs/plugins/convert.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/plugins/convert.rst b/docs/plugins/convert.rst index ff439eb97..aa28ed240 100644 --- a/docs/plugins/convert.rst +++ b/docs/plugins/convert.rst @@ -165,7 +165,7 @@ command to use to transcode audio. The tokens ``$source`` and ``$dest`` in the command are replaced with the paths to the existing and new file. The plugin in comes with default commands for the most common audio -formats: `mp3`, `alac`, `flac`, `aac`, `opus`, `ogg`, `wmv`. For +formats: `mp3`, `alac`, `flac`, `aac`, `opus`, `ogg`, `wma`. For details have a look at the output of ``beet config -d``. For a one-command-fits-all solution use the ``convert.command`` and From fd37fec73ec125e5c2dc7b17bd20ac88a966f3b4 Mon Sep 17 00:00:00 2001 From: Aidan Epstein Date: Sat, 30 Jul 2022 16:15:44 +0000 Subject: [PATCH 3/3] Update changelog.rst --- docs/changelog.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/changelog.rst b/docs/changelog.rst index f42257448..163e69f72 100644 --- a/docs/changelog.rst +++ b/docs/changelog.rst @@ -90,6 +90,7 @@ Bug fixes: * :doc:`plugins/importadded`: Fix a bug with recently added reflink import option that casues a crash when ImportAdded plugin enabled. :bug:`4389` +* :doc:`plugins/convert`: Fix a bug with the `wma` format alias. For packagers: