Backup_Repos/beets
1
0
Fork 0
mirror of https://github.com/beetbox/beets.git synced 2026-02-09 17:01:55 +01:00
Code Issues Projects Releases Wiki Activity

mbsync: use separate structure for old_data

Browse source 
Assigning an attribute on Items doesn't really work here since we try to store
that value to the DB as a flexattr.
This commit is contained in:
Adrian Sampson 2013-08-23 14:01:31 -07:00
parent 5e09c5e473
commit 343a85d482
1 changed files with 8 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
beetsplug/mbsync.py
View file

@ -24,14 +24,14 @@ from beets import config
log = logging.getLogger('beets')
def _print_and_apply_changes(lib, item, move, pretend, write):
def _print_and_apply_changes(lib, item, old_data, move, pretend, write):
"""Apply changes to an Item and preview them in the console. Return
a boolean indicating whether any changes were made.
"""
changes = {}
for key in library.ITEM_KEYS_META:
if 'key' in item._dirty:
changes[key] = item.old_data[key], getattr(item, key)
if key in item._dirty:
changes[key] = old_data[key], getattr(item, key)
if not changes:
return False
@ -69,7 +69,7 @@ def mbsync_singletons(lib, query, move, pretend, write):
.format(s.title))
continue
s.old_data = dict(s)
old_data = dict(s)
# Get the MusicBrainz recording info.
track_info = hooks.track_for_mbid(s.mb_trackid)
@ -80,7 +80,7 @@ def mbsync_singletons(lib, query, move, pretend, write):
# Apply.
with lib.transaction():
autotag.apply_item_metadata(s, track_info)
_print_and_apply_changes(lib, s, move, pretend, write)
_print_and_apply_changes(lib, s, old_data, move, pretend, write)
def mbsync_albums(lib, query, move, pretend, write):
@ -93,8 +93,7 @@ def mbsync_albums(lib, query, move, pretend, write):
continue
items = list(a.items())
for item in items:
item.old_data = dict(item)
old_data = {item: dict(item) for item in items}
# Get the MusicBrainz album information.
album_info = hooks.album_for_mbid(a.mb_albumid)
@ -116,8 +115,8 @@ def mbsync_albums(lib, query, move, pretend, write):
autotag.apply_metadata(album_info, mapping)
changed = False
for item in items:
changed = _print_and_apply_changes(lib, item, move, pretend,
write) or changed
changed |= _print_and_apply_changes(lib, item, old_data[item],
move, pretend, write)
if not changed:
# No change to any item.
continue