From 2cab2d670aa011006f4322a59176ba3dbb6bb22b Mon Sep 17 00:00:00 2001 From: Rob Crowell Date: Tue, 25 Jan 2022 16:13:05 -0800 Subject: [PATCH] Fix bug in StringQuery.string_match --- beets/dbcore/query.py | 2 +- test/test_query.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/beets/dbcore/query.py b/beets/dbcore/query.py index c020deacb..b0c769790 100644 --- a/beets/dbcore/query.py +++ b/beets/dbcore/query.py @@ -191,7 +191,7 @@ class StringQuery(StringFieldQuery): @classmethod def string_match(cls, pattern, value): - return pattern == value + return pattern.lower() == value.lower() class SubstringQuery(StringFieldQuery): diff --git a/test/test_query.py b/test/test_query.py index 0b857ef7c..0be4b7d7f 100644 --- a/test/test_query.py +++ b/test/test_query.py @@ -395,12 +395,12 @@ class MatchTest(_common.TestCase): def test_exact_match_nocase_positive(self): q = dbcore.query.StringQuery('genre', 'the genre') self.assertTrue(q.match(self.item)) + q = dbcore.query.StringQuery('genre', 'THE GENRE') + self.assertTrue(q.match(self.item)) def test_exact_match_nocase_negative(self): q = dbcore.query.StringQuery('genre', 'genre') self.assertFalse(q.match(self.item)) - q = dbcore.query.StringQuery('genre', 'THE GENRE') - self.assertFalse(q.match(self.item)) def test_year_match_positive(self): q = dbcore.query.NumericQuery('year', '1')