diff --git a/test/test_ui.py b/test/test_ui.py index 86c40d204..a1e02aaae 100644 --- a/test/test_ui.py +++ b/test/test_ui.py @@ -701,27 +701,30 @@ class UpdateTest(_common.TestCase): item = self.lib.items().get() self.assertEqual(item.title, 'full') - @unittest.expectedFailure def test_multivalued_albumtype_roundtrip(self): # https://github.com/beetbox/beets/issues/4528 # albumtypes is empty for our test fixtures, so populate it first album = self.album - # setting albumtypes does not set albumtype currently... - # FIXME: When actually fixing the issue 4528, consider whether this - # should be set to "album" or ["album"] - album.albumtype = "album" - album.albumtypes = "album" + correct_albumtypes = ["album", "live"] + + # Setting albumtypes does not set albumtype, currently. + # Using x[0] mirrors https://github.com/beetbox/mediafile/blob/057432ad53b3b84385e5582f69f44dc00d0a725d/mediafile.py#L1928 + correct_albumtype = correct_albumtypes[0] + + album.albumtype = correct_albumtype + album.albumtypes = correct_albumtypes album.try_sync(write=True, move=False) album.load() - albumtype_before = album.albumtype - self.assertEqual(albumtype_before, "album") + self.assertEqual(album.albumtype, correct_albumtype) + self.assertEqual(album.albumtypes, correct_albumtypes) self._update() album.load() - self.assertEqual(albumtype_before, album.albumtype) + self.assertEqual(album.albumtype, correct_albumtype) + self.assertEqual(album.albumtypes, correct_albumtypes) class PrintTest(_common.TestCase):